No description provided.
[Wallet][Trivial] Rename usehd option to createhdwallet #8377
pull pstratem wants to merge 1 commits into bitcoin:master from pstratem:2016-07-16-cwallet-createhdwallet changing 3 files +8 −8-
pstratem commented at 2:44 AM on July 20, 2016: contributor
- pstratem force-pushed on Jul 20, 2016
- pstratem renamed this:
Rename usdhd option to createhdwallet
Rename usehd option to createhdwallet
on Jul 20, 2016 -
Rename usehd option to createhdwallet ba28be51f9
- pstratem force-pushed on Jul 20, 2016
- pstratem renamed this:
Rename usehd option to createhdwallet
[Wallet][Trivial] Rename usehd option to createhdwallet
on Jul 20, 2016 -
laanwj commented at 7:07 AM on July 20, 2016: member
This was discussed in #8035: #8035 (comment) and there was no clear preference for renaming it.
- laanwj added the label Wallet on Jul 20, 2016
-
MarcoFalke commented at 8:04 AM on July 20, 2016: member
@pstratem The goal was to have this a permanent option and not an option only for the first start of the client. I.e. you set whether you prefer to usehd or not in your conf file. Thus, the client can warn you if the underlying wallet does not comply your preference.
-
pstratem commented at 8:11 AM on July 20, 2016: contributor
@MarcoFalke OK is there an upgrade strategy?
-
MarcoFalke commented at 8:14 AM on July 20, 2016: member
Not for 0.13. But I think there are plans to use
-upgradewalletor similar to create a HD seed in 0.14. -
jonasschnelli commented at 8:37 AM on July 20, 2016: contributor
I think we should keep
-usehd=1for now. We need to think about ...- if and how we are going to allow HD for already existing wallets
- How a user could input a seed (xpriv) during hd wallet creation (I guess a config argument
-hdmasterkey=<xpriv>would not be the best way to do this, adding an RPC call would allow to pass in a master key at the stage where the wallet has already been created).
-
laanwj commented at 9:07 AM on August 3, 2016: member
The rationale for keeping the option named as-is has been explained, no need to rename, closing this.
- laanwj closed this on Aug 3, 2016
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels