0.13.0rc1: bitcoin-qt db cache not increased to 300 MB on upgrade from 0.12.1 #8406

1. 
   harding commented at 9:33 AM on July 26, 2016: contributor

   When upgrading from 0.12.1 to 0.13.0rc1, bitcoin-qt continues to use a db cache of 100 MB although the release notes lead me to expect that it should be set to 300 MB:

   

   Steps to reproduce

   Platform: Debian 8 guest on Xen (QubesOS) host; uname: Linux debian-8-dvm 4.1.13-9.pvops.qubes.x86_64 [#1](/bitcoin-bitcoin/1/) SMP Thu Feb 11 15:46:02 UTC 2016 x86_64 GNU/Linux

   1. On a fresh Debian 8 install
   2. Download https://bitcoin.org/bin/bitcoin-core-0.12.1/bitcoin-0.12.1-linux64.tar.gz
   3. Untar and run bitcoin-0.12.1/bin/bitcoin-qt -maxconnections=0
   4. Open settings screen; note that db cache set to 100 MB (as expected for 0.12.1)
   5. Close 0.12.1
   6. Download https://bitcoin.org/bin/bitcoin-core-0.13.0/test.rc1/bitcoin-0.13.0rc1-x86_64-linux-gnu.tar.gz
   7. Untar and run bitcoin-0.13.0/bin/bitcoin-qt -maxconnections=0
   8. Open settings screen; note that db cache still set to 100 MB (see screenshot above)

   Expected behavior

   Since I never changed any settings in 0.12.1 away from their defaults, I'd expect them to be upgraded to the new defaults.

   Notes

   I suppose there's a case to be made for not automatically changing any setting specified in the configuration dialog once the user has seen it. If that's the intended behavior, then please feel free to close this issue (and accept my apologies for taking up your time).

2. 
   sipa commented at 9:35 AM on July 26, 2016: member

   I assume this is due to the dbcache setting being overridden by the setting in the GUI.

   I wonder how. I guess it would require an explicit "if previous setting was 100, change it to $default instead... but keep storing it as 100".

3. 
   jonasschnelli commented at 10:10 AM on July 26, 2016: contributor

   I'll check this. In the meantime @harding: could you try running the Bitcoin-Qt with --resetguisettings and see if it sets back the dbache to 300?

4. 
   harding commented at 10:12 AM on July 26, 2016: contributor

   @jonasschnelli Restarting with bitcoin-0.13.0/bin/bitcoin-qt -maxconnections=0 --resetguisettings does indeed set the dbcache to 300.

5. 
   jonasschnelli commented at 11:27 AM on July 26, 2016: contributor

   Unfortunately, the GUI stores the default values in its own GUI settings file (managed through Qt). https://github.com/bitcoin/bitcoin/blob/0.13/src/qt/optionsmodel.cpp#L90

   Changing the default value of -dbcache, -par, -upnp, -listen will not make its way into the GUI.

   We could (and probably should) add some simple migration code where we explicit check if the dbcache value is 100 during the first start of 0.13 GUI, if so, we bump to the new default and remember that the check/firststart has been done.

6. jonasschnelli added the label GUI on Jul 26, 2016
7. jonasschnelli added this to the milestone 0.13.0 on Jul 26, 2016
8. 
   laanwj commented at 9:31 AM on July 28, 2016: member

   Fixed by #8407

9. laanwj closed this on Jul 28, 2016

   ---

10. MarcoFalke locked this on Sep 8, 2021

Milestone
0.13.0