gettransaction RPC for non-wallet transactions #841

1. 
   sipa commented at 5:46 PM on February 15, 2012: member

   Works for wallet transactions, memory-pool transaction and block chain transactions.

   Available for all:

   • txid
   • version
   • locktime
   • size
   • coinbase/inputs/outputs
   • confirmations

   Available only for wallet transactions:

   • amount
   • fee
   • details
   • blockindex

   Available for wallet transactions and block chain transactions:

   • blockhash
   • time
2. 
   jgarzik commented at 5:40 AM on February 17, 2012: contributor

   visual ACK

3. 
   gavinandresen commented at 6:35 PM on February 17, 2012: contributor

   Sanity tested OK; would be nice if it checked the memory pool for 0-confirmation "other people's" transactions.

4. 
   sipa commented at 10:41 PM on February 19, 2012: member

   @gavinandresen done

5. in src/bitcoinrpc.cpp:None in dee753ae94 outdated

   1506 | +    else
   1507 | +    {
   1508 | +        CTxDB txdb("r");
   1509 | +        CTransaction tx;
   1510 | +        CTxIndex txindex;
   1511 | +        if (!tx.ReadFromDisk(txdb, COutPoint(hash, 0), txindex))
   

   ---

   ---

   

   gavinandresen commented at 5:07 PM on February 22, 2012:

   Doesn't this ReadFromDisk() fail for memory pool transactions? I could've sworn memory pool txns weren't written to disk until they were included in a block...

6. 
   sipa commented at 8:30 PM on February 22, 2012: member

   Much more complete and totally reworked version pushed.

7. 
   luke-jr commented at 2:39 AM on April 10, 2012: member

   Needs rebasing. Sipa broke everything using locks. >_<

8. 
   luke-jr commented at 2:37 AM on April 18, 2012: member

   This needs rebasing (merges clean, but won't build)

9. gettransaction RPC for non-wallet transactions

   Works for wallet transactions, memory-pool transaction and block chain
   transactions.
   
   Available for all:
    * txid
    * version
    * locktime
    * size
    * coinbase/inputs/outputs
    * confirmations
   
   Available only for wallet transactions:
    * amount
    * fee
    * details
    * blockindex
   
   Available for wallet transactions and block chain transactions:
    * blockhash
    * time

   c73ba23eb5
10. 
    sipa commented at 9:42 PM on April 18, 2012: member

    rebased

11. gmaxwell referenced this in commit 2f1dca645b on May 8, 2012
12. gmaxwell merged this on May 8, 2012
13. gmaxwell closed this on May 8, 2012

    ---

14. coblee referenced this in commit 27e260d650 on Jul 17, 2012
15. destenson referenced this in commit 11d9330eda on Jun 26, 2016
16. sipa referenced this in commit 6c0259fc2f on Oct 28, 2020
17. fanquake referenced this in commit bd27ab1f97 on Oct 28, 2020
18. DrahtBot locked this on Sep 8, 2021

Milestone
0.7.0