Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock #8413

pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:0.13-consensus-last-params changing 2 files +5 −5
  1. jtimon commented at 9:49 pm on July 27, 2016: contributor

    Pre-witness my plan was to get rid of ContextualCheckBlock and move its check to ConnectBlock/Consensus::VerifyTx, so this was not necessary.

    This should be the last existing consensus function that needs to get Consensus::Params instead of ChainParams or call Params() from inside.

  2. Trivial: pass Consensus::Params& instead of CChainParams& in ContextualCheckBlock c8664eeac7
  3. jtimon force-pushed on Jul 27, 2016
  4. jtimon commented at 9:58 pm on July 27, 2016: contributor
    Sorry, contained an old TODO that wasn’t true. Updated. Ping @NicolasDorier @dcousens
  5. dcousens commented at 1:24 am on July 28, 2016: contributor
    utACK c8664ee
  6. NicolasDorier commented at 2:27 am on July 28, 2016: contributor
    utACK c8664eeac75fb87282dc69049cfa23d583742629
  7. jonasschnelli added the label Refactoring on Jul 28, 2016
  8. sipa commented at 7:45 pm on July 29, 2016: member
    utACK c8664eeac75fb87282dc69049cfa23d583742629
  9. btcdrak commented at 10:29 pm on July 31, 2016: contributor
    utACK c8664ee
  10. sipa merged this on Jul 31, 2016
  11. sipa closed this on Jul 31, 2016

  12. sipa referenced this in commit 8ea7d31e38 on Jul 31, 2016
  13. codablock referenced this in commit 449b28ca0e on Sep 19, 2017
  14. codablock referenced this in commit 1ac348176b on Dec 29, 2017
  15. codablock referenced this in commit aa6c37919b on Jan 8, 2018
  16. andvgal referenced this in commit 2280d1db66 on Jan 6, 2019
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me