[QA] Add walletdump RPC test (including HD- & encryption-tests) #8417

   0 | @@ -0,0 +1,120 @@
   1 | +#!/usr/bin/env python3
   2 | +# Copyright (c) 2016 The Bitcoin Core developers
   3 | +# Distributed under the MIT software license, see the accompanying
   4 | +# file COPYING or http://www.opensource.org/licenses/mit-license.php.
   5 | +
   6 | +from test_framework.test_framework import BitcoinTestFramework
   7 | +from test_framework.util import *
   8 | +import os
   9 | +import shutil

MarcoFalke commented at 10:40 AM on August 1, 2016:

Unused import

  38 | +        inputfile = open(tmpdir + "/node0/wallet.unencrypted.dump")
  39 | +        found_addr = 0
  40 | +        found_addr_chg = 0
  41 | +        found_addr_rsv = 0
  42 | +        hdmasteraddr = ""
  43 | +        for line in inputfile:

MarcoFalke commented at 10:40 AM on August 1, 2016:

No need to duplicate this huge for loop

  68 | +                        elif (keytype == "reserve=1"):
  69 | +                            found_addr_rsv+=1
  70 | +                            break
  71 | +        assert(found_addr == test_addr_count) #all keys must be in the dump
  72 | +        assert(found_addr_chg == 50) #50 blocks where mined
  73 | +        assert(found_addr_rsv == 100) #100 reserve keys (keypool)

MarcoFalke commented at 10:41 AM on August 1, 2016:

Please use assert_equal, otherwise it is harder to track down when an issue arises

  73 | +        assert(found_addr_rsv == 100) #100 reserve keys (keypool)
  74 | +
  75 | +        #encrypt wallet, restart, unlock and dump
  76 | +        self.nodes[0].encryptwallet('test')
  77 | +        bitcoind_processes[0].wait()
  78 | +        self.nodes[0] = start_node(0, self.options.tmpdir)

MarcoFalke commented at 10:42 AM on August 1, 2016:

You are starting with the default keypool of 1 (for the test framework). This may cause issues in the future.

  44 | +            #only read non comment lines
  45 | +            if line[0] != "#" and len(line) > 10:
  46 | +                #split out some data
  47 | +                keyLabel, comment = line.split("#")
  48 | +                key = keyLabel.split(" ")[0]
  49 | +                keytype = keyLabel.split(" ")[2]

MarcoFalke commented at 10:43 AM on August 1, 2016:

Nit: use_lowercase_and_underscore

  43 | +        for line in inputfile:
  44 | +            #only read non comment lines
  45 | +            if line[0] != "#" and len(line) > 10:
  46 | +                #split out some data
  47 | +                keyLabel, comment = line.split("#")
  48 | +                key = keyLabel.split(" ")[0]

MarcoFalke commented at 10:43 AM on August 1, 2016:

Unused variable