Enable size accounting in mining unit tests #8419

1. 
   sdaftuar commented at 6:34 pm on July 28, 2016: member

   This change to the unit test should have happened in #8295. Now that size accounting is supported by the mining algorithm, we shouldn’t disable size accounting in the mining unit tests.
2. Enable size accounting in mining unit tests 8bfd70817b
3. jonasschnelli added the label Tests on Jul 28, 2016
4. 
   sipa commented at 11:44 pm on July 28, 2016: member

   utACK 8bfd70817bf8b8b07b81660e47c88dd122b7423f
5. MarcoFalke added the label Mining on Jul 31, 2016
6. 
   paveljanik commented at 7:50 pm on July 31, 2016: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/8419/commits/8bfd70817bf8b8b07b81660e47c88dd122b7423f
7. 
   paveljanik commented at 8:01 pm on July 31, 2016: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/8419/commits/8bfd70817bf8b8b07b81660e47c88dd122b7423f
8. in src/test/miner_tests.cpp: in 8bfd70817b

   180@@ -181,9 +181,7 @@ void TestPackageSelection(const CChainParams& chainparams, CScript scriptPubKey,
   181 // NOTE: These tests rely on CreateNewBlock doing its own self-validation!
   182 BOOST_AUTO_TEST_CASE(CreateNewBlock_validity)
   183 {
   184-    // Disable size accounting (CPFP does not support it)
   185-    mapArgs["-blockmaxsize"] = strprintf("%u", MAX_BLOCK_SERIALIZED_SIZE);
   186-
   187+    // Note that by default, these tests run with size accounting enabled.
   

   ---

   ---

   

   laanwj commented at 8:42 am on August 1, 2016:

   Whoa, this global state was set without reverting it again at the end of the testcase? Please don’t do that.

   In any case ACK.

9. laanwj merged this on Aug 1, 2016
10. laanwj closed this on Aug 1, 2016

    ---

11. laanwj referenced this in commit ea268747b6 on Aug 1, 2016
12. luke-jr referenced this in commit a7aa3ccc4f on Sep 21, 2016
13. DrahtBot locked this on Sep 8, 2021

Contributors
sdaftuar sipa paveljanik laanwj

Labels
Tests Mining