Fix p2p-feefilter.py for changed tx relay behavior #8444

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:fix-feefilter-test changing 1 files +12 −2
  1. sdaftuar commented at 5:17 PM on August 1, 2016: member

    This is an alternative to #8316 for fixing #7148 (comment).

    The basic problem with the test that is failing is that we don't have a way to know if the next poisson relay time has occurred, if we're trying to test that nothing is inv'ed. This fix adds something that we expect to be inv'ed, and the test now assumes that anything else that would be relayed would have been relayed at the same time.

    It's unfortunate that this is still somewhat dependent on how transactions are batched for announcement, but this at least improves the situation so that the test should now reliably succeed on master. And given that the implementation of feefilter is highly dependent on the transaction relay code anyway, it's not clear how much of a separation we could reasonably expect to achieve in the test.

  2. Fix p2p-feefilter.py for changed tx relay behavior 2c517b3928
  3. MarcoFalke commented at 8:50 PM on August 1, 2016: member

    Thanks, I forgot about #8316. Removing the hardcoded constant clearly makes sense.

    This is an improvement and should also be backported to fix the test failures.

    utACK 2c517b3

  4. laanwj added the label Tests on Aug 3, 2016
  5. laanwj added the label Needs backport on Aug 3, 2016
  6. laanwj merged this on Aug 4, 2016
  7. laanwj closed this on Aug 4, 2016

  8. laanwj referenced this in commit 6e6ab2c323 on Aug 4, 2016
  9. MarcoFalke referenced this in commit cd0910b787 on Aug 4, 2016
  10. MarcoFalke removed the label Needs backport on Aug 8, 2016
  11. codablock referenced this in commit 551e1b47cf on Sep 19, 2017
  12. codablock referenced this in commit e741ce67fd on Dec 29, 2017
  13. codablock referenced this in commit 549894bac7 on Jan 8, 2018
  14. andvgal referenced this in commit e811d5b049 on Jan 6, 2019
  15. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me