The last update of secp256k1 has been ~9 months ago (6c527ec), probably it is time to update the subtree again. At least the (experimental) ARM assembly has been merged since.
According to @sipa on IRC “there are certainly no regressions known that would make the current master less appropriate than the subtree in bitcoin currently”
utACK 103f1e8
0$ ./contrib/devtools/git-subtree-check.sh src/secp256k1
1src/secp256k1 in HEAD was last updated to upstream commit c5b32e16c4d2560ce829caf88a413fc06fd83d09 (tree cabf1a0476632c9ac99946c39e663a681cc019ae)
2src/secp256k1 in HEAD currently refers to tree cabf1a0476632c9ac99946c39e663a681cc019ae
3GOOD
Removal of <string.h> include is probably the source of this warning:
0+In file included from src/secp256k1.c:14:
1+./src/ecmult_impl.h:186:9: warning: implicitly declaring library function 'memcpy' with type 'void *(void *, const void *, unsigned long)'
2+ memcpy(dst->pre_g, src->pre_g, size);
3+ ^
4+./src/ecmult_impl.h:186:9: note: include the header <string.h> or explicitly provide a declaration for 'memcpy'
5+./src/ecmult_impl.h:230:5: warning: implicitly declaring library function 'memset' with type 'void *(void *, int, unsigned long)'
6+ memset(wnaf, 0, len * sizeof(wnaf[0]));
7+ ^
8+./src/ecmult_impl.h:230:5: note: include the header <string.h> or explicitly provide a declaration for 'memset'
9+2 warnings generated.
Reported upstream (https://github.com/bitcoin-core/secp256k1/issues/409).
7a49cac Merge #410: Add string.h include to ecmult_impl
0bbd5d4 Add string.h include to ecmult_impl
c5b32e1 Merge #405: Make secp256k1_fe_sqrt constant time
926836a Make secp256k1_fe_sqrt constant time
e2a8e92 Merge #404: Replace 3M + 4S doubling formula with 2M + 5S one
8ec49d8 Add note about 2M + 5S doubling formula
5a91bd7 Merge #400: A couple minor cleanups
ac01378 build: add -DSECP256K1_BUILD to benchmark_internal build flags
a6c6f99 Remove a bunch of unused stdlib #includes
65285a6 Merge #403: configure: add flag to disable OpenSSL tests
a9b2a5d configure: add flag to disable OpenSSL tests
b340123 Merge #402: Add support for testing quadratic residues
e6e9805 Add function for testing quadratic residue field/group elements.
efd953a Add Jacobi symbol test via GMP
fa36a0d Merge #401: ecmult_const: unify endomorphism and non-endomorphism skew cases
c6191fd ecmult_const: unify endomorphism and non-endomorphism skew cases
0b3e618 Merge #378: .gitignore build-aux cleanup
6042217 Merge #384: JNI: align shared files copyright/comments to bitcoinj's
24ad20f Merge #399: build: verify that the native compiler works for static precomp
b3be852 Merge #398: Test whether ECDH and Schnorr are enabled for JNI
aa0b1fd build: verify that the native compiler works for static precomp
eee808d Test whether ECDH and Schnorr are enabled for JNI
7b0fb18 Merge #366: ARM assembly implementation of field_10x26 inner (rebase of #173)
001f176 ARM assembly implementation of field_10x26 inner
0172be9 Merge #397: Small fixes for sha256
3f8b78e Fix undefs in hash_impl.h
2ab4695 Fix state size in sha256 struct
6875b01 Merge #386: Add some missing `VERIFY_CHECK(ctx != NULL)`
2c52b5d Merge #389: Cast pointers through uintptr_t under JNI
43097a4 Merge #390: Update bitcoin-core GitHub links
31c9c12 Merge #391: JNI: Only call ecdsa_verify if its inputs parsed correctly
1cb2302 Merge #392: Add testcase which hits additional branch in secp256k1_scalar_sqr
d2ee340 Merge #388: bench_ecdh: fix call to secp256k1_context_create
093a497 Add testcase which hits additional branch in secp256k1_scalar_sqr
a40c701 JNI: Only call ecdsa_verify if its inputs parsed correctly
faa2a11 Update bitcoin-core GitHub links
47b9e78 Cast pointers through uintptr_t under JNI
f36f9c6 bench_ecdh: fix call to secp256k1_context_create
bcc4881 Add some missing `VERIFY_CHECK(ctx != NULL)` for functions that use `ARG_CHECK`
6ceea2c align shared files copyright/comments to bitcoinj's
70141a8 Update .gitignore
7b549b1 Merge #373: build: fix x86_64 asm detection for some compilers
bc7c93c Merge #374: Add note about y=0 being possible on one of the sextic twists
e457018 Merge #364: JNI rebased
86e2d07 JNI library: cleanup, removed unimplemented code
3093576a JNI library
bd2895f Merge pull request #371
e72e93a Add note about y=0 being possible on one of the sextic twists
3f8fdfb build: fix x86_64 asm detection for some compilers
e5a9047 [Trivial] Remove double semicolons
c18b869 Merge pull request #360
3026daa Merge pull request #302
03d4611 Add sage verification script for the group laws
a965937 Merge pull request #361
83221ec Add experimental features to configure
5d4c5a3 Prevent damage_array in the signature test from going out of bounds.
419bf7f Merge pull request #356
03d84a4 Benchmark against OpenSSL verification
git-subtree-dir: src/secp256k1
git-subtree-split: 7a49cacd3937311fcb1cb36b6ba3336fca811991
0$ ./contrib/devtools/git-subtree-check.sh src/secp256k1
1src/secp256k1 in HEAD was last updated to upstream commit 7a49cacd3937311fcb1cb36b6ba3336fca811991 (tree cfd05e78e0a117016efa89cd75e4ac5a938219cb)
2src/secp256k1 in HEAD currently refers to tree cfd05e78e0a117016efa89cd75e4ac5a938219cb
3GOOD
utACK
Travis failure in segwit.py (https://travis-ci.org/bitcoin/bitcoin/jobs/152624836#L7727) interesting, but probably unrelated.
0$ contrib/devtools/git-subtree-check.sh src/secp256k1
1src/secp256k1 in HEAD was last updated to upstream commit 7a49cacd3937311fcb1cb36b6ba3336fca811991 (tree cfd05e78e0a117016efa89cd75e4ac5a938219cb)
2src/secp256k1 in HEAD currently refers to tree cfd05e78e0a117016efa89cd75e4ac5a938219cb
3GOOD
Labels
Utils/log/libs