[Trivial] Do not shadow variables in networking code #8466

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160805_Wshadow_net changing 5 files +13 −13

paveljanik commented at 7:07 PM on August 5, 2016: contributor

This is a followup to #8105.

Networking code contains several shadowed variables. Fixes use underscore prefix with the only exception - IPv6 address called for adding 6 to the variable name. I'm open for suggestions. @theuni Please review if it conflicts with your code.

For review, compare binaries or compile with -Wshadow and compare complete logs.
theuni commented at 8:11 PM on August 5, 2016: member

utACK
jonasschnelli added the label Refactoring on Aug 8, 2016
sipa commented at 6:08 AM on August 10, 2016: member

utACK fccd99aa183b96865120cfe7637c7e70b0c9db33
MarcoFalke commented at 6:27 AM on August 10, 2016: member

utACK fccd99a (gives same binaries)
paveljanik commented at 11:39 AM on August 15, 2016: contributor

#8128 merged, will rebase soon.
Do not shadow variables in networking code b7c349d5e7
paveljanik force-pushed on Aug 15, 2016
sipa commented at 9:17 AM on August 18, 2016: member

reutACK b7c349d5e7c207bb7a2e7469c3e5522c9909c17f
MarcoFalke commented at 5:36 PM on August 18, 2016: member

reutACK b7c349d (still gives same binaries)
laanwj merged this on Sep 2, 2016
laanwj closed this on Sep 2, 2016
laanwj referenced this in commit cbe9ae8c69 on Sep 2, 2016
codablock referenced this in commit 5f7d85713a on Sep 19, 2017
codablock referenced this in commit edf4c22e23 on Jan 9, 2018
codablock referenced this in commit 313cfb09da on Jan 9, 2018
andvgal referenced this in commit 61bf7a3b01 on Jan 6, 2019
random-zebra referenced this in commit 777638e7bc on Aug 27, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8105 avoid shadowing vars, and enable -Wshadow