Ubuntu 14.04 server installs w/o curl #8478

pull unsystemizer wants to merge 1 commits into bitcoin:master from unsystemizer:patch-3 changing 1 files +1 −1

unsystemizer commented at 4:50 AM on August 7, 2016: contributor

... so make HOST=arm-linux-gnueabihf NO_QT=1 fails if curl is missing.

Ubuntu 14.04 server installs w/o curl

... so `make HOST=arm-linux-gnueabihf NO_QT=1` fails if curl is missing.

fc7c43a537

MarcoFalke added the label Docs and Output on Aug 7, 2016
MarcoFalke added the label Needs backport on Aug 7, 2016
MarcoFalke commented at 8:13 AM on August 7, 2016: member

Concept ACK fc7c43a537f58b5befc8a8d9c2797ddaa06fa7a0. Does this need backport to 0.13?
paveljanik commented at 8:18 AM on August 7, 2016: contributor

I do not think adding it into documentation is enough... Check for it or install it (I do not know the exact depends workings).
paveljanik commented at 8:22 AM on August 7, 2016: contributor

And as curl is needed for other archs, it should be inserted elsewhere anyway.
MarcoFalke commented at 8:32 AM on August 7, 2016: member
The same is missing here:
```
doc/build-windows.md:First install the toolchains:
```

josephbisch commented at 10:29 PM on August 7, 2016: none

We could do something like the following:

From 7deb7fc636717b6a0457039bf10d6c5b81076d3f Mon Sep 17 00:00:00 2001
From: Joseph Bisch <joseph.bisch@gmail.com>
Date: Sun, 7 Aug 2016 16:17:11 -0600
Subject: [PATCH] Depends: Check if curl is installed and error out if not

---
 depends/Makefile | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/depends/Makefile b/depends/Makefile
index dedb067..7937c54 100644
--- a/depends/Makefile
+++ b/depends/Makefile
@@ -18,6 +18,8 @@ DOWNLOAD_RETRIES:=3
 HOST_ID_SALT ?= salt
 BUILD_ID_SALT ?= salt

+CURL := $(shell command -v curl 2> /dev/null)
+
 host:=$(BUILD)
 ifneq ($(HOST),)
 host:=$(HOST)
@@ -168,7 +170,11 @@ check-packages: check-sources
 install: check-packages $(host_prefix)/share/config.site


-download-one: check-sources $(all_sources)
+download-one:
+ifndef CURL
+   $(error "curl is not available, please install curl")
+endif
+   check-sources $(all_sources)

 download-osx:
    @$(MAKE) -s HOST=x86_64-apple-darwin11 download-one
-- 
2.9.0

Which looks like:

Makefile:175: *** "curl is not available, please install curl".  Stop.
make: *** [Makefile:182: download-linux] Error 2

But I don't think that is much more helpful over the default make message about curl missing. People should be able to tell what to do if they get a message about curl missing.

If anything we should display a message. I don't think we should be trying to figure out how to install curl on Linux and OS X. The user knows best how to use the package manager to install software. And we can't just add curl as another piece of software that is built by the depends process, because we use curl to download the source code. So we end up with a situation where we need curl to download curl source to build curl binary to download...and so on in a circular fashion.

MarcoFalke commented at 5:38 AM on August 8, 2016: member

There is no plan to add curl to depends. Initially we used wget which happens to be installed on ubuntu out of the box. Due to intermittent problems, it was switched to curl, which happens not to be installed by default. As those docs refer to 'ubuntu vm', it makes sense to mention that curl is needed.

in doc/build-unix.md:None in fc7c43a537

 292 | @@ -293,7 +293,7 @@ These steps can be performed on, for example, an Ubuntu VM. The depends system
 293 |  will also work on other Linux distributions, however the commands for
 294 |  installing the toolchain will be different.
 295 |  
 296 | -First install the toolchain:
 297 | +First install the toolchain (you may need to install curl, too):
 298 |  
 299 |      sudo apt-get install g++-arm-linux-gnueabihf
 300 |

rebroad commented at 5:46 AM on August 9, 2016:

further below, a "./autogen.sh" is needed before the "./configure"...

luke-jr commented at 3:17 AM on August 29, 2016:

Unrelated to this PR, and incorrect: build-unix is written for the user (ie, downloading the source tarball), but autogen is needed only for developers (ie, from git).

laanwj commented at 1:42 PM on August 11, 2016: member
I'd suggest to just add 'curl' to the apt-get line, this more copy-paste friendly:
```
First install the toolchain and curl:

     sudo apt-get install g++-arm-linux-gnueabihf curl
```
There is no hurt in installing it if it is already installed.
MarcoFalke commented at 3:13 PM on August 11, 2016: member

I'd suggest to just add 'curl' to the apt-get line, this more copy-paste friendly:

Agree
theuni commented at 6:03 PM on August 11, 2016: member

Agreed.
laanwj commented at 1:58 PM on August 13, 2016: member

BTW: this was never meant to be a complete list of necessary packages. I'm quite sure you needed to install automake, libtool, pkg-config, bsdmainutils too? (and possibly others, but this is from looking at the top of build-unix.md for host-side tools)
MarcoFalke commented at 4:46 PM on August 18, 2016: member

@laanwj I think people can figure that out on themselves, but curl is now required by depends, so it should be mentioned.
MarcoFalke commented at 4:46 PM on August 18, 2016: member

@unsystemizer Are you still working on this?
MarcoFalke added this to the milestone 0.13.1 on Aug 18, 2016
laanwj commented at 9:37 AM on August 19, 2016: member

I think people can figure that out on themselves, but curl is now required by depends, so it should be mentioned.

Are you sure? I forgot to install pkg-config on my windows cross-build host once, with surprising results (though that part has been solved, see #8228). If I make dumb mistakes like that, I wouldn't expect anything different from people doing this for the first time.
MarcoFalke removed the label Needs backport on Aug 29, 2016
sipa closed this on Aug 29, 2016
unsystemizer deleted the branch on Sep 15, 2016
unsystemizer restored the branch on Sep 15, 2016
unsystemizer deleted the branch on Sep 15, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Milestone
0.13.1

Linked (view graph)

#8624 [doc] build: Mention curl