[wallet] Add high transaction fee warnings #8486

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1607-walletHighFeeWarn changing 4 files +24 −8

MarcoFalke commented at 1:50 PM on August 8, 2016: member

Add missing warnings to mintxfee and minrelaytxfee (c.f warnings for fallbackfee and paytxfee)
MarcoFalke added the label Docs and Output on Aug 8, 2016
MarcoFalke added the label Wallet on Aug 8, 2016
MarcoFalke force-pushed on Aug 8, 2016
MarcoFalke force-pushed on Aug 8, 2016
in src/init.cpp:None in fa304ad52c outdated
```
 960 | +        if (!ParseMoney(mapArgs["-minrelaytxfee"], n))
 961 |              return InitError(AmountErrMsg("minrelaytxfee", mapArgs["-minrelaytxfee"]));
 962 | +#ifdef ENABLE_WALLET
 963 | +        if (!fDisableWallet && n > HIGH_TX_FEE_PER_KB)
 964 | +            InitWarning(AmountHighWarn("-minrelaytxfee") + " " +
 965 | +                        _("This is the minimum transaction fee you pay on every transaction."));
```
sipa commented at 5:35 AM on August 10, 2016:

Minrelayfee influences more than the fee you pay yourself. Isn't it a bit confusing to advertize it as just that?

MarcoFalke commented at 7:18 AM on August 10, 2016:

Right, but this is irrelevant for the wallet. If you run with the wallet disabled, you can use minrelayfee with the feefilter to approach a -blocksonly mode for minrelayfee → ∞.

With the wallet enabled, it should warn when you are about to pay a fee too high.

I have moved this code to wallet.cpp to make that clearer.

in src/wallet/wallet.cpp:None in fa304ad52c outdated

3442 | @@ -3441,6 +3443,7 @@ bool CWallet::ParameterInteraction()
3443 |              return InitError(AmountErrMsg("paytxfee", mapArgs["-paytxfee"]));
3444 |          if (nFeePerK > HIGH_TX_FEE_PER_KB)
3445 |              InitWarning(_("-paytxfee is set very high! This is the transaction fee you will pay if you send a transaction."));

sipa commented at 5:36 AM on August 10, 2016:

Use AmountHighWarn here as well?

MarcoFalke commented at 7:20 AM on August 10, 2016:

Done

MarcoFalke force-pushed on Aug 10, 2016
sipa commented at 1:22 PM on August 25, 2016: member

utACK

in src/init.cpp:None in 0000b603d8 outdated

 958 | -            ::minRelayTxFee = CFeeRate(n);
 959 | -        else
 960 | +        if (!ParseMoney(mapArgs["-minrelaytxfee"], n))
 961 |              return InitError(AmountErrMsg("minrelaytxfee", mapArgs["-minrelaytxfee"]));
 962 | +        // High fee check is done afterward in CWallet::ParameterInteraction()
 963 | +        ::minRelayTxFee = CFeeRate(n);

luke-jr commented at 3:13 AM on August 29, 2016:

Why is this being rearranged? It seems functionally identical except missing the n>0 check?

MarcoFalke commented at 7:47 AM on August 29, 2016:

We don't use the n>0 elsewhere because it is redundant:

src/test/util_tests.cpp:    BOOST_CHECK(!ParseMoney("-1", ret));

Also, the syntax is preferable:

if(fail)
  return;
doStuff();

if(!fail)
  doStuff();
else
  return;

luke-jr commented at 3:14 AM on August 29, 2016: member

Concept ACK
[wallet] Add high transaction fee warnings faef293cf3
MarcoFalke force-pushed on Sep 25, 2016
MarcoFalke commented at 8:07 AM on September 26, 2016: member

(trivial rebase)
laanwj commented at 11:54 AM on September 26, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/8486/commits/faef293cf311a1063b31f90b645cb491d0140930
laanwj merged this on Sep 26, 2016
laanwj closed this on Sep 26, 2016
laanwj referenced this in commit ab0b411868 on Sep 26, 2016
morcos commented at 12:03 PM on September 26, 2016: member

@laanwj I was about to comment but wanted to test first. Doesn't his make setting a minrelaytxfee of 0 possible whereas it previously wasn't? That might be OK but just wanted to point it out.
laanwj commented at 12:19 PM on September 26, 2016: member

Doesn't his make setting a minrelaytxfee of 0 possible whereas it previously wasn't?

This is in fact the case, good catch. Not sure if this is a problem, but I don't think it was intended.
MarcoFalke deleted the branch on Sep 26, 2016
codablock referenced this in commit 576a992597 on Sep 19, 2017
codablock referenced this in commit d87c156f19 on Jan 11, 2018
andvgal referenced this in commit 0205c52220 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8814 [wallet, policy] ParameterInteraction: Don't allow 0 fee