Bugfix: Use pre-BIP141 sigops until segwit activates (GBT) #8489

1. 
   luke-jr commented at 10:01 PM on August 8, 2016: member

   We are currently giving BIP141 sigop values in block templates even before BIP141 is active.

   This is broken in 0.13 and will need a backport. (although not sure it's worth delaying 0.13.0 over?)

   Includes RPC test improvements to catch the issue, which now pass with the fix.

2. Bugfix: Use pre-BIP141 sigops until segwit activates 160f895a80
3. qa/rpc-tests/segwit: Test GBT sigops before and after activation 239cbd2e5c
4. 
   luke-jr commented at 10:06 PM on August 8, 2016: member

   Only known practical real-world effect: Eloipool currently ignores sigoplimit, but will enforce 19,488 "sigops"; this bug will cause it to enforce instead 4,872. This seems sufficiently large that it shouldn't affect ordinary blocks, but I'm not sure how malicious transactions might factor into it.

5. jonasschnelli added the label Consensus on Aug 9, 2016
6. 
   sipa commented at 5:23 AM on August 10, 2016: member

   utACK 239cbd2e5c2a36843b45b356e9aea6e8d35f0968

7. sipa added this to the milestone 0.13.0 on Aug 10, 2016
8. laanwj merged this on Aug 10, 2016
9. laanwj closed this on Aug 10, 2016

   ---

10. laanwj referenced this in commit edebf425a2 on Aug 10, 2016
11. laanwj referenced this in commit 8b0eee66e9 on Aug 10, 2016
12. MarcoFalke locked this on Sep 8, 2021

Milestone
0.13.0