[init, wallet] ParameterInteraction() iff wallet enabled #8494

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1608-initWalletParamInt changing 1 files +1 −1

MarcoFalke commented at 6:43 AM on August 10, 2016: member

This is only required when the wallet is enabled.
[init] ParameterInteraction() iff wallet enabled fa5d276c90
MarcoFalke added the label Wallet on Aug 10, 2016
laanwj commented at 6:53 AM on August 10, 2016: member

Yes, that makes some sense.

Although in the end it depends on where we want to handle wallet enabled/disabled, or "which and how many wallets to load" - if we want to handle that externally in the wallet module (if compiled in) then this is a move the wrong way around.
MarcoFalke commented at 7:16 AM on August 10, 2016: member

@laanwj I am fine with either. I just feel we should have it in at least in one place.
jonasschnelli commented at 11:32 AM on August 11, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/pull/8494/commits/fa5d276c906214ef959529fd6cde0b78bd67ed8e
MarcoFalke commented at 1:10 PM on August 24, 2016: member

Trivial PR. Does this require more review?
jonasschnelli commented at 1:24 PM on August 24, 2016: contributor
I think this PR is ready. Though, long term, we should "modularize" CWallet. Which means, init.cpp doesn't need to know about the wallet-disable state.

The only hooks in init.cpp should probably be:
- CWallet::GetWalletHelpString()
- CWallet::ParameterInteraction()
- CWallet::Verify()
- CWallet::InitLoadWallet()
and maybe a
- CWallet::CleanUp() in the destructor or shutdown logic.
This should probably the "module pattern" that could also be used for TxIndex, Miner, Stats-Module, etc.
paveljanik commented at 1:29 PM on August 24, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/8494/commits/fa5d276c906214ef959529fd6cde0b78bd67ed8e
MarcoFalke commented at 7:48 AM on September 19, 2016: member

@laanwj Anything holding this back?
sipa approved
sipa commented at 9:16 AM on September 19, 2016: member

utACK
laanwj commented at 9:38 AM on September 19, 2016: member

Which reminds me: we need tests for parameter interaction (especially the privacy relevant settings). utACK fa5d276
laanwj merged this on Sep 19, 2016
laanwj closed this on Sep 19, 2016
laanwj referenced this in commit a5b20edd3d on Sep 19, 2016
MarcoFalke deleted the branch on Sep 19, 2016
codablock referenced this in commit 5512e528db on Sep 19, 2017
codablock referenced this in commit 9432e1904f on Jan 11, 2018
andvgal referenced this in commit 3b29e9b6a1 on Jan 6, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels