Wrong validity in IsRFC4843() #850

issue mad opened this issue on February 16, 2012
  1. mad commented at 4:08 PM on February 16, 2012: none

    RFC483 say:

     Prefix          : A constant 28-bit-long bitstring value
                       (2001:10::/28).
    

    RFC483 check is perform there:

    https://github.com/bitcoin/bitcoin/blob/master/src/netbase.cpp#L403

    We check: GetByte(12) & 0xF0 == 0x10

    But we must check: (GetByte(12) & 0xF0) == 0x10

    it seems to be typo

  2. laanwj closed this on Feb 17, 2012

  3. laanwj commented at 1:41 PM on February 17, 2012: member

    Thanks!

  4. sje397 referenced this in commit 9e06873ae3 on Feb 17, 2012
  5. coblee referenced this in commit ec52b9733f on Jul 17, 2012
  6. destenson referenced this in commit b5924a2451 on Jun 26, 2016
  7. ptschip referenced this in commit 937628d514 on Dec 5, 2017
  8. lateminer referenced this in commit e488db7334 on Apr 6, 2019
  9. sipa referenced this in commit c020cbaa5c on Jul 14, 2021
  10. MarcoFalke locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me