test: Remove java comparison tool #8504

1. 
   laanwj commented at 2:11 pm on August 13, 2016: member

   There is a growing number of issues with it, and no one is really maintaining it anymore. From #4545 (comment):

   Seems I’ll just have to set a deadline: I’m going to remove use of the unmaintained java-based comparison framework after the 0.13 branch-off (projected 2016-07-06, see #7679). I hope the Python framework will be a full replacement by then, but as this is holding up progress in other areas, that will not affect the decision. @MarcoFalke worded it quite well too:

   If they don’t and no one knows how to fix, we can remove them right now. Because the only thing they’d be doing then, is slowing down travis.

   • The effort of porting the java comparison tool to Python is going very well, see e.g. #8141. If there is something left to do, I’m sure it can be resolved before the 0.14 release.
   • The test is blocking changes such as #7093 (Address mempool information leak and resource wasting attacks).
   • This test takes quite a while and is holding up enabling the tests for win32: #8227.
   • comparison tool support seems to have been dropped from the v0.14 release of bitcoinj (discovered @droark)

   This removes all the support for the tool, and removes it from depends (and hopefully all other references to it).

   Not to be backported to 0.13.

2. test: Remove java comparison tool 3c5251daeb
3. laanwj added the label Tests on Aug 13, 2016
4. 
   MarcoFalke commented at 2:31 pm on August 13, 2016: member

   Thank you!

   ACK 3c5251d

5. MarcoFalke added the label Build system on Aug 13, 2016
6. 
   sipa commented at 9:08 am on August 16, 2016: member

   Concept ACK
7. 
   laanwj commented at 9:13 am on August 16, 2016: member

   @theuni can you have a look at the depends/build system changes here?
8. 
   droark commented at 9:43 am on August 16, 2016: contributor

   ACK

   Definitely not the person to sign off on the depends/build system changes but what I see strikes me as pretty thorough. I did a bit of a deep dive awhile back and seem to recall what’s here as being everything that’s related to the tool.

9. 
   theuni commented at 4:23 pm on August 16, 2016: member

   Woohoo, great to see this! Thanks to everyone involved.

   Build-side looks good. The .travis.yaml can drop the hostname hack since we no longer require java, but that can be done as a follow-up.

   utACK.

10. travis: Remove hostname hack

    This was required for java, and we no longer use java for the tests.

    eb0c52ec1d
11. 
    laanwj commented at 10:04 am on August 17, 2016: member

    @theuni Did I remove the right hack?
12. 
    MarcoFalke commented at 11:00 am on August 17, 2016: member

    Yes, eb0c52e looks right. (c.f. #8253)
13. laanwj merged this on Aug 17, 2016
14. laanwj closed this on Aug 17, 2016

    ---

15. laanwj referenced this in commit 733035bdb7 on Aug 17, 2016
16. 
    theuni commented at 4:28 pm on August 17, 2016: member

    @laanwj yup, thanks.
17. codablock referenced this in commit a06d67f744 on Sep 19, 2017
18. sickpig referenced this in commit fdef26fb66 on Oct 17, 2017
19. sickpig referenced this in commit ff4ad40c9d on Oct 19, 2017
20. zkbot referenced this in commit 75604363cc on Dec 1, 2017
21. zkbot referenced this in commit 6aef4033a7 on Dec 1, 2017
22. zkbot referenced this in commit 83af270002 on Dec 15, 2017
23. codablock referenced this in commit a14c1d0896 on Dec 29, 2017
24. codablock referenced this in commit e6dca369e6 on Jan 8, 2018
25. kotodev referenced this in commit c8a979fc92 on Jan 25, 2018
26. renium9 referenced this in commit 23640da445 on Feb 6, 2018
27. andvgal referenced this in commit bb37618f25 on Jan 6, 2019
28. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj MarcoFalke sipa droark theuni

Labels
Build system Tests