Show in GUI the type of Wallet (HD or old non-HD) #8508

issue ghost openend this issue on August 13, 2016
  1. ghost commented at 8:44 pm on August 13, 2016: none

    Using 0.13.0rc1 (or rc2?) I emptied my old non-HD wallet, shutdown bitcoin-core, moved the old wallet.dat away and started bitcoin-core again, to get a new HD wallet created. So the new wallet should be a HD wallet, because I did not change the default “-usehd” option value of 1.

    But I would like to see a confirmation of my guess somewhere in the GUI, maybe in the debug window, or maybe under Help->About wallet. Maybe also the wallet should have a version number to be able to clearly identifiy the type of wallet (e.g. wallet type version 1 = HD Wallet)

  2. MarcoFalke commented at 8:53 pm on August 13, 2016: member
    I think you can try “About”->“Debug window”->“Console” and type in getwalletinfo. Search for walletversion and hdmasterkeyid.
  3. MarcoFalke added the label GUI on Aug 13, 2016
  4. ghost commented at 8:58 pm on August 13, 2016: none
    Thanks for the tip. Walletversion is 130000 and there is a hdmasterkeyid shown. So I guess all is ok. Maybe a little GUI info would be nice for people who do not bother researching and executing rpc commands
  5. luke-jr commented at 9:50 pm on August 13, 2016: member
    Sounds reasonable to add the wallet version to the debug console maybe?
  6. jonasschnelli added the label Easy to implement on Aug 15, 2016
  7. laanwj commented at 10:01 am on August 19, 2016: member

    Sounds reasonable to add the wallet version to the debug console maybe?

    getwalletinfo would be the place for that. I’m surprised it isn’t in there yet. Oh wait it is:

    0obj.push_back(Pair("walletversion", pwalletMain->GetVersion()));
    
  8. MarcoFalke commented at 5:02 pm on August 19, 2016: member
    Anything left to do here?
  9. jonasschnelli commented at 5:04 pm on August 19, 2016: contributor
    Closing, fixed by #8517.
  10. jonasschnelli closed this on Aug 19, 2016

  11. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 19:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me