Precompute sighashes #8524

1. 
   sipa commented at 1:15 PM on August 16, 2016: member

   Alternative to #8422.

   This version simply precomputes the 3 overall hashes once per transaction, resulting in no more cache that needs updating during validation.

2. Precompute sighashes

   Original version by Nicolas Dorier. Precomputing version by Pieter Wuille.

   d2c5d044d0
3. 
   NicolasDorier commented at 1:36 PM on August 16, 2016: contributor

   utACK 67a2091463b7d9f3d33d86fb42a6feab127a9487 will test and time it soon. I prefer this version as well.

4. Unit test for sighash caching ab48c5e721
5. sipa force-pushed on Aug 16, 2016
6. MarcoFalke added the label Needs backport on Aug 16, 2016
7. MarcoFalke added this to the milestone 0.13.1 on Aug 16, 2016
8. 
   instagibbs commented at 1:26 PM on August 22, 2016: member

   Prefer the simplicity of this one.

   code review ACK and lightly tACK(it syncs testnet) https://github.com/bitcoin/bitcoin/pull/8524/commits/ab48c5e72156b34300db4a6521cb3c9969be3937

9. 
   dcousens commented at 1:41 PM on August 22, 2016: contributor

   utACK ab48c5e

10. in src/script/interpreter.h:None in ab48c5e721 outdated

      97 | @@ -98,13 +98,20 @@ enum
      98 |  
      99 |  bool CheckSignatureEncoding(const std::vector<unsigned char> &vchSig, unsigned int flags, ScriptError* serror);
     100 |  
     101 | +struct CachedHashes
    

    ---

    ---

    

    laanwj commented at 1:01 PM on August 26, 2016:

    Nit: this struct name is too general, maybe CachedTransactionHashes?

    ---

    

    sipa commented at 4:32 PM on August 26, 2016:

    It's actually not a cache either anymore.

    What about PrecomputedTransactionData ?

    ---

    

    sipa commented at 4:39 PM on August 26, 2016:

    Added a commit.

11. 
    laanwj commented at 1:19 PM on August 26, 2016: member

    utACK ab48c5e, nice to get rid of some TODOs and spurious hashing

12. sipa force-pushed on Aug 26, 2016
13. Rename to PrecomputedTransactionData 35fe0393f2
14. sipa force-pushed on Aug 26, 2016
15. 
    btcdrak commented at 9:18 AM on August 28, 2016: contributor

    utACK 35fe039

16. 
    sipa commented at 12:16 PM on August 28, 2016: member

    @laanwj Ok with the class name now?

17. sipa merged this on Sep 1, 2016
18. sipa closed this on Sep 1, 2016

    ---

19. sipa referenced this in commit 19b0f33de0 on Sep 1, 2016
20. MarcoFalke removed the label Needs backport on Sep 9, 2016
21. zkbot referenced this in commit 84c19b8a87 on Feb 8, 2018
22. zkbot referenced this in commit e1f3a15fdc on Feb 8, 2018
23. zkbot referenced this in commit eb3128ab0a on Feb 19, 2018
24. zkbot referenced this in commit 6db10127a9 on Feb 20, 2018
25. zkbot referenced this in commit 8487be8360 on Feb 20, 2018
26. PastaPastaPasta referenced this in commit 56803dca64 on Jun 6, 2019
27. PastaPastaPasta referenced this in commit 1e72c9308d on Jun 7, 2019
28. PastaPastaPasta referenced this in commit 923fcfd430 on Jun 7, 2019
29. PastaPastaPasta referenced this in commit b9a16505d9 on Jun 7, 2019
30. PastaPastaPasta referenced this in commit 3ed43c9667 on Jun 10, 2019
31. PastaPastaPasta referenced this in commit 7696cc9a22 on Jun 10, 2019
32. PastaPastaPasta referenced this in commit c9db36882c on Jun 10, 2019
33. PastaPastaPasta referenced this in commit 9be6722049 on Jun 11, 2019
34. PastaPastaPasta referenced this in commit 2afd050865 on Jun 11, 2019
35. barrystyle referenced this in commit 618457c5dd on Jan 22, 2020
36. random-zebra referenced this in commit 5a092159f6 on Aug 5, 2020
37. DrahtBot locked this on Sep 8, 2021

Contributors

sipaNicolasDorierinstagibbsdcousenslaanwjbtcdrak

Milestone
0.13.1