As noticed by @luke-jr in the august 4th IRC meeting (see http://www.erisian.com.au/meetbot/bitcoin-core-dev/2016/bitcoin-core-dev.2016-08-04-19.00.log.html), no feefilter messages are sent as long as the mempool does not fill up. Send at least the minFeeFilter rate.
Take minRelayTxFee into account in FEEFILTER messages #8527
pull sipa wants to merge 1 commits into bitcoin:master from sipa:clampfeefilter changing 1 files +1 −1-
sipa commented at 4:02 PM on August 16, 2016: member
-
Take minRelayTxFee into account in FEEFILTER messages d302879ef9
-
btcdrak commented at 4:20 PM on August 16, 2016: contributor
utACK d302879
- MarcoFalke added this to the milestone 0.13.1 on Aug 16, 2016
-
MarcoFalke commented at 4:30 PM on August 16, 2016: member
utACK d302879. Tagged for future release (0.13.1)
- MarcoFalke added the label TX fees and policy on Aug 16, 2016
- MarcoFalke added the label P2P on Aug 16, 2016
- MarcoFalke added the label Needs backport on Aug 16, 2016
-
sipa commented at 4:34 PM on August 16, 2016: member
I just realized that this may be intentional, as we perhaps still do accept sub-minrelayfee transactions ("free transactions") before the mempool fills up?
-
MarcoFalke commented at 4:44 PM on August 16, 2016: member
Correct. If we stopped handling free transactions, quite a lot of code would simplify/can be deleted.
- MarcoFalke removed the label Needs backport on Aug 16, 2016
- MarcoFalke removed this from the milestone 0.13.1 on Aug 16, 2016
-
MarcoFalke commented at 4:48 PM on August 16, 2016: member
I think this patch passes the extended rpc test suite. This reminds me that a small test (maybe for the extended suite) could be helpful to check that priority transactions don't break accidentally.
-
MarcoFalke commented at 6:57 PM on August 23, 2016: member
Closing. Apparently, we need tests for priority or remove it, but this should be done in a separate pull.
- MarcoFalke closed this on Aug 23, 2016
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels