I wish I could merge it with #8505
Trivial: little typos #8537
pull ghost wants to merge 1 commits into bitcoin:master from changing 2 files +2 −2-
ghost commented at 11:24 AM on August 18, 2016: none
-
Trivial: 2 typos [skip ci] b6190a7a9e
- jonasschnelli added the label Docs and Output on Aug 18, 2016
-
jonasschnelli commented at 2:02 PM on August 18, 2016: contributor
Trivial ACK b6190a7a9e36101b0e1a41c4e969db4cdb3ec1a5.It's good to have only a few of these typo fix PRs and combine them as much as possible to not disturb other PRs. -
sipa commented at 2:15 PM on August 18, 2016: member
Please don't change code inside the leveldb subtree directly. You could do so through the https://github.com/bitcoin/leveldb repository (which is sometimes synced with the src/leveldb directory), however.
-
jonasschnelli commented at 2:16 PM on August 18, 2016: contributor
Oh. Right. Change is on a subtree. un-Trivial-ACK.
-
ghost commented at 2:31 PM on August 18, 2016: none
It's good to have only a few of these typo fix PRs and combine them as much as possible to not disturb other PRs.
Yes, 2 typos for a Pull Request isn't enough.
I'll close this Pull Request because...
Please don't change code inside the leveldb subtree directly. You could do so through the https://github.com/bitcoin/leveldb repository (which is sometimes synced with the src/leveldb directory), however.
...because I'll open A Pull Request in leveldb repo.
- unknown closed this on Aug 18, 2016
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels