Remove IP transaction check #8538

pull ghost wants to merge 4 commits into bitcoin:master from changing 1 files +13 −35

ghost commented at 1:04 PM on August 18, 2016: none

The code checking for 'online' IP transactions can be removed.

~ laanwj #8530 (comment)

I attempted to remove it and when I tested it, it compiled succesfully.

in src/qt/transactiondesc.cpp:None in 596f40a282 outdated

 160 | @@ -180,22 +161,21 @@ QString TransactionDesc::toHTML(CWallet *wallet, CWalletTx &wtx, TransactionReco
 161 |                  if ((toSelf == ISMINE_SPENDABLE) && (fAllFromMe == ISMINE_SPENDABLE))
 162 |                      continue;
 163 |  
 164 | -                if (!wtx.mapValue.count("to") || wtx.mapValue["to"].empty())
 165 | +
 166 | +                // Offline transaction

jonasschnelli commented at 1:06 PM on August 18, 2016:

Can we remove the term "offline transaction"? I think it's confusion.

jonasschnelli added the label GUI on Aug 18, 2016
MarcoFalke commented at 4:11 PM on August 18, 2016: member
Please get rid of the merge commit according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

You can try
```
git reset 67df90a~
git commit src/qt
```
or
```
git rebase bitcoin/master
```
where bitcoin refers to the remote pointing to this repo.
MarcoFalke commented at 4:11 PM on August 18, 2016: member

Concept ACK!
laanwj commented at 7:33 AM on August 19, 2016: member

concept ACK, looks good to me, although I have not verified that this doesn't affect payment request functionality (does anything else set transaction metadata 'from' and 'to'?)
luke-jr commented at 8:33 AM on August 19, 2016: member

How does this affect a wallet that has received IP payments in the past?
laanwj commented at 8:47 AM on August 19, 2016: member

Yes, that should be tested, if anyone still has such a wallet around. Crashing would be unacceptable, showing it differently would be.
MarcoFalke commented at 9:10 AM on August 19, 2016: member

Please also get rid of the other tr("From").
laanwj commented at 9:34 AM on August 19, 2016: member

BTW: do we do anything special in the transaction overview for these kind of transactions? if so, that code should go at the same time
Remove IP transaction check 58ff2d8b84
ghost commented at 10:25 AM on August 19, 2016: none
```
git reset 67df90a~
git commit src/qt
```
I tried this but they conflicted. Now this has 16 files changed.

Update: I give up. 172 files changed.
? d70185724b
MarcoFalke commented at 10:27 AM on August 19, 2016: member
@mcccs Sry, I forgot to mention you also need to rebase on master after that. You can join the developer chat and we are happy to help, btw.
```
git rebase f4e777819c54fe0e386de517a201053698556236
```
Remove IP transaction check d9ce6c1949
Merge remote-tracking branch 'origin/Ip-check' into Ip-check e853eac0bf
ghost commented at 10:30 AM on August 19, 2016: none

Why did it commit "Merge remote-tracking branch 'origin/Ip-check' into Ip-check"? I didn't do that.

Update: moved to #8546
unknown closed this on Aug 19, 2016
unknown deleted the branch on Aug 19, 2016
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#8530 Remove `from` field