Trivial: Fix typos in various files #8541

leijurv commented at 5:13 PM on August 18, 2016: contributor

It seems that "initializ-" is the standard, and not "initialis-"

$ grep -r "initialis" src/ | grep -v "qt/locale" | wc -l
       2
$ grep -r "initializ" src/ | grep -v "qt/locale" | wc -l
      151

in src/wallet/wallet.cpp:None in c049f24557 outdated

3373 | @@ -3374,7 +3374,7 @@ bool CWallet::InitLoadWallet()
3374 |                  block = block->pprev;
3375 |  
3376 |              if (pindexRescan != block)
3377 | -                return InitError(_("Prune: last wallet synchronisation goes beyond pruned data. You need to -reindex (download the whole blockchain again in case of pruned node)"));
3378 | +                return InitError(_("Prune: last wallet synchronization goes beyond pruned data. You need to -reindex (download the whole blockchain again in case of pruned node)"));

MarcoFalke commented at 5:17 PM on August 18, 2016:

I think translators already take care of localisation (or localization).

leijurv commented at 5:21 PM on August 18, 2016:

My goal was to have a standard spelling internally, for things that would never be shown to the user (such as comments as well as localization strings)

leijurv commented at 5:24 PM on August 18, 2016:

Ah, I just realized that discounting files in qt/locale was not a good idea

$ grep -r "Prune: last wallet synchronisation goes beyond pruned data." . | wc -l
      23
$

leijurv commented at 5:24 PM on August 18, 2016:

I'll revert the synchronisation vs synchnonization one.

btcdrak commented at 5:21 PM on August 18, 2016: contributor

I disagree these are typos. The spelling is correct.

leijurv commented at 5:21 PM on August 18, 2016: contributor

They go against the standard spelling defined elsewhere. They might not be typos, true, because there are multiple accepted spellings, but they are definitely outliers compared to the rest of the codebase. I show this in the pull request description.

btcdrak commented at 5:24 PM on August 18, 2016: contributor

@leijurv I am not aware we demand one spelling over the other. It shouldn't matter for either comments or translation strings since they are handled by translators.

leijurv commented at 5:25 PM on August 18, 2016: contributor

I standardized the spellings of reorganis/ze, serialis/ze, optimis/ze in this pull request: #8505 Why not initialis/ze too? @btcdrak

various typos 3e3abba394

leijurv force-pushed on Aug 18, 2016

MarcoFalke commented at 5:34 PM on August 18, 2016: member

Keep in mind most developers are international and do not speak English as their native tongue. It probably will turn out difficult to enforce spelling.

If you feel strong about typos, there would be another one: git grep communc

leijurv commented at 5:36 PM on August 18, 2016: contributor

Okay. Why was #8505 accepted then? Was that an error or something?

MarcoFalke commented at 5:38 PM on August 18, 2016: member

The other pull fixed some actual typos

On Thu, Aug 18, 2016 at 7:37 PM, Leijurv notifications@github.com wrote:

Okay. Why was #8505 accepted then? Was than an error or something?

leijurv commented at 5:40 PM on August 18, 2016: contributor

Would you accept a pull request to revert the non-typos fixed by #8505? Specifically the correction of outlying spellings of reorganis/ze, serialis/ze, and optimis/ze?

jonasschnelli added the label Docs and Output on Aug 19, 2016

jonasschnelli commented at 6:29 AM on August 19, 2016: contributor

IMO such pull requests are not productive... they may are if they fix many of typos in one PR. Closing.

jonasschnelli closed this on Aug 19, 2016

laanwj commented at 10:14 AM on August 19, 2016: member

Agree with @jonasschnelli and @MarcoFalke , too much of this is not productive. These are just code comments, if they're hard to understand, then certainly fixing a few typos isn't going to make that better.

Try to restrict fixing typos to end-user facing messages.

MarcoFalke locked this on Sep 8, 2021