Different recommendations for “maxuploadtarget” in docs vs. 13.0rc3 debug.log #8555

issue ghost openend this issue on August 20, 2016
  1. ghost commented at 3:03 pm on August 20, 2016: none

    Using 13.0rc3 Here https://github.com/bitcoin/bitcoin/blob/master/doc/reduce-traffic.md is written, regarding -maxuploadtarget: “The recommended minimum is 144 blocks per day (max. 144MB per day)”.

    Using -maxuploadtarget=200 leads to the following message in debug.log: “Max outbound target is very small (209715200 bytes) and will be overshot. Recommended minimum is 576000000 bytes.”

    The different recommendations should be harmonized.

    I would also suggest to consistentley use “MiB”. E.g. no “MB”.

    Instead of “Recommended minimum is 576000000 bytes.” I would suggest to write “Recommended minimum is 550 MiB.” (rounded up)

    Instead of “Max outbound target is very small (209715200 bytes) …” should be written “Max outbound target is very small (200 MiB) …”

  2. jonasschnelli commented at 4:03 pm on August 20, 2016: contributor
    Thanks for the report. I’ll have a look at that.
  3. MarcoFalke added the label Docs and Output on Aug 20, 2016
  4. MarcoFalke added the label Easy to implement on Aug 20, 2016
  5. MarcoFalke commented at 5:22 pm on August 20, 2016: member
    This was missed in 2b1f6f9cc, should be easy to fix.
  6. sipa commented at 8:48 am on August 22, 2016: member
    Fix for 0.13.0?
  7. MarcoFalke added this to the milestone 0.13.1 on Aug 22, 2016
  8. jonasschnelli commented at 11:40 am on August 22, 2016: contributor
    Its just a warning, the miscalculation is a little bit ugly, but I think a fix in 0.13.1 is okay.
  9. jonasschnelli added the label Needs backport on Aug 30, 2016
  10. jonasschnelli removed the label Needs backport on Aug 30, 2016
  11. laanwj commented at 8:30 am on September 14, 2016: member
    Closed by #8712
  12. laanwj closed this on Sep 14, 2016

  13. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me