[Wallet] remove unused code/conditions in ReadAtCursor #8564

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/08/bdb_abstraction_1 changing 3 files +9 −11

jonasschnelli commented at 1:41 PM on August 23, 2016: contributor

Long term goal should be to provide alternative database connectors for our wallet. I have worked out a flexible adaptor like pattern that would allow a drop-in-alternative/replacement for BDB (https://github.com/jonasschnelli/bitcoin/tree/2016/08/bdb_abstract_prework).

This is a small, easy-to-review trivial PR towards this direction.

CDB::ReadAtCursor() has some unused flags handling (which would be relative hard to abstract for other databases). It seems like it only used to set a filter for the key (DB_SET_RANGE).

This removes unused code and simplifies CDB::ReadAtCursor() logic.
[Wallet] remove unused code/conditions in ReadAtCursor beef966e36
jonasschnelli added the label Refactoring on Aug 23, 2016
jonasschnelli added the label Wallet on Aug 23, 2016
sipa commented at 5:21 PM on August 26, 2016: member

utACK beef966e365e16a9b041321e404f7cd21a4e999e
luke-jr commented at 3:47 AM on August 27, 2016: member

utACK
paveljanik commented at 12:12 PM on August 29, 2016: contributor

utACK https://github.com/bitcoin/bitcoin/pull/8564/commits/beef966e365e16a9b041321e404f7cd21a4e999e
sipa merged this on Aug 29, 2016
sipa closed this on Aug 29, 2016
sipa referenced this in commit 01680195f8 on Aug 29, 2016
codablock referenced this in commit 78e637e114 on Sep 19, 2017
codablock referenced this in commit 8d5ecf7c91 on Jan 9, 2018
codablock referenced this in commit 707e2945a4 on Jan 9, 2018
andvgal referenced this in commit 387aa6048e on Jan 6, 2019
random-zebra referenced this in commit 46fad30bbb on Nov 15, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels