Disable building against Qt4 #8588

issue jonasschnelli opened this issue on August 25, 2016
  1. jonasschnelli commented at 8:24 AM on August 25, 2016: contributor

    Maintaining compatibility with Qt4 seems to be "lost efforts".

    We should disable the --with-gui=qt4 option and also disable the auto-detect of qt4 in bitcoin_qt.m4.

  2. jonasschnelli added the label GUI on Aug 25, 2016
  3. jonasschnelli added this to the milestone 0.14.0 on Aug 25, 2016
  4. jonasschnelli assigned theuni on Aug 25, 2016
  5. MarcoFalke commented at 8:42 AM on August 25, 2016: member

    related issue: #8263

  6. MarcoFalke commented at 9:47 AM on August 25, 2016: member

    Conclusion:

    jonasschnelli:  If someone really wants to compile against qt4, we could keep --with-gui=qt4 but disable the autodetect
    wumpus:  jonasschnelli: good idea; you can still force using it if you know what you're doing, but it wil never choose it by default
    luke-jr:  jonasschnelli: that sounds reasonable; maybe a message to make noises if they want Qt4 support to stay?
    
    
  7. laanwj commented at 11:39 AM on September 21, 2016: member

    So the conclusion here is to stop auto-detecting qt4, but allow it to be chosen?

    Yea, maybe, though that means we can still get complaints that qt4 doesn't work. That meeting was a month ago and I've seen zero pull requests fixing qt4 issues.

  8. luke-jr commented at 7:23 PM on September 21, 2016: member

    So the conclusion here is to stop auto-detecting qt4, but allow it to be chosen?

    IIRC yes.

    That meeting was a month ago and I've seen zero pull requests fixing qt4 issues.

    I found no issues when testing with Qt4. It just works.

  9. laanwj commented at 2:27 AM on September 22, 2016: member

    So #8586 (the tab switching problem that makes qt4 unusable) was false alarm? Okay, strange.

  10. laanwj commented at 2:28 AM on September 22, 2016: member

    Closing this then in favor of #8263, apparently there is no immediate problem, one issue for Qt4 EOL should be enough.

  11. laanwj closed this on Sep 22, 2016

  12. luke-jr commented at 3:56 AM on September 22, 2016: member

    Right, neither I nor the original reporter could reproduce the problem in #8586

  13. DrahtBot locked this on Sep 8, 2021
Labels

Milestone
0.14.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me