[Wallet] Ensure <0.13 clients can't open HD wallets #8595

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:2016/07/hd_minversion changing 1 files +3 −0

rebroad commented at 1:24 AM on August 26, 2016: contributor

This commit developed by Jonas Schnelli appears to be in 0.13 but isn't in the master branch. Isn't this functionality also needed in 0.14 onwards?

I suspect this should either be in master (as it is in 0.13), or it got somehow left in 0.13 by mistake (e.g. was supposed to be removed by #8378).
[Wallet] Ensure <0.13 clients can't open HD wallets 332b5cdd57
jonasschnelli commented at 6:23 AM on August 26, 2016: contributor

This is not required (was changed in 0.14 over #8378). Your PR would result in setting the nMinVersion twice (https://github.com/bitcoin/bitcoin/blob/master/src/wallet/wallet.cpp#L1214).

NACK.
jonasschnelli added the label Wallet on Aug 26, 2016
laanwj closed this on Aug 26, 2016
rebroad deleted the branch on Aug 28, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels