I asked @sipa what to use in C++11 instead of introducing a new boost::scoped_ptr and he answered std::unique_ptr. Then I realized that completely replacing boost::scoped_ptr with std::unique_ptr is currently quite trivial, just a diff of +11 -11.
C++11: s/boost::scoped_ptr/std::unique_ptr/ #8629
pull jtimon wants to merge 1 commits into bitcoin:master from jtimon:0.13-boost-scoped-ptr changing 9 files +11 −12-
jtimon commented at 8:49 PM on August 30, 2016: contributor
-
dcousens commented at 10:40 PM on August 30, 2016: contributor
utACK 06a214a
- fanquake added the label Refactoring on Aug 31, 2016
-
laanwj commented at 12:44 PM on August 31, 2016: member
utACK 06a214a
-
sipa commented at 12:57 PM on August 31, 2016: member
Seem pretty uninvasive. utACK 06a214aeaaa6ef12c11c20bb774ff0e065707afc
-
paveljanik commented at 1:11 PM on August 31, 2016: contributor
Please also remove the include (https://github.com/paveljanik/bitcoin/commit/775ac957b7754dd8d1d51a93d5d6dc85fbbfc3bc).
cACK (compilesACK) https://github.com/bitcoin/bitcoin/commit/06a214aeaaa6ef12c11c20bb774ff0e065707afc
-
laanwj commented at 2:22 PM on September 1, 2016: member
Please also remove the include (paveljanik@775ac95).
Agreed. I'm surprised that that's the only instance.
- jtimon force-pushed on Sep 1, 2016
-
jtimon commented at 4:00 PM on September 1, 2016: contributor
@paveljanik Good catch! I greped boost/scoped_ptr but saw a bunch of hits in .Po files and missed that one. It is still being included implicitly to the other places somehow, but yeah, that include had to go.
-
C++11: s/boost::scoped_ptr/std::unique_ptr/ cdd79eb70f
- jtimon force-pushed on Sep 1, 2016
-
paveljanik commented at 7:12 AM on September 2, 2016: contributor
- laanwj merged this on Sep 2, 2016
- laanwj closed this on Sep 2, 2016
- laanwj referenced this in commit 6f939c9080 on Sep 2, 2016
- codablock referenced this in commit 5ee03a5e49 on Sep 19, 2017
- codablock referenced this in commit 88c35eb7d0 on Jan 9, 2018
- codablock referenced this in commit 414272af93 on Jan 9, 2018
- andvgal referenced this in commit 31be1cd212 on Jan 6, 2019
- random-zebra referenced this in commit 46fad30bbb on Nov 15, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels