Do not shadow upper local variable 'send', prevent -Wshadow compiler warning. #8677

Fixes new -Wshadow (#8105) warning from #8606:

Making all in src
  CXX      libbitcoin_server_a-main.o
main.cpp:4792:30: warning: declaration shadows a local variable [-Wshadow]
                        bool send = false;
                             ^
main.cpp:4748:22: note: previous declaration is here
                bool send = false;
                     ^
1 warning generated.

It would be nice to get rid of it completely and sending merkleblock only when something like merkleBlock.initialized(), but there is no getter now and all properties are marked as public only for unit testing.

utACK

utACK https://github.com/bitcoin/bitcoin/pull/8677/commits/125b946cb4412fdf92bc3a68e6030bf4ddfe752d

utACK 125b946

utACK 125b946

Fixes new -Wshadow (#8105) warning from #8606:

Looks like these are being introduced faster than they can be cleaned up...

So maybe it's time to enable this warning in the default bulid?

Anyhow, executables match, ACK 125b946

Not yet, I think. There are approx. 500 of these warnings in Qt 8)

Is it possible to only compile everything not UI with -Wshadow ?

There surely is a way to disable -Wshadow for qt ;-)

We shouldn't be making lots of changes to local variable names because they conflict with a global variable. That's just treating the symptoms, we need to address the root cause, which is the large number of globals.

There is almost no change like you describe (tableRPC being an exception). You are stating pure truth though.