This fixes a possible shutdown crash. Thanks to @morcos for reporting.
In the case of (for example) an already-running bitcoind, the shutdown sequence begins before CConnman has been created, leading to a null-pointer dereference when g_connman->Stop() is called.
Concept ACK, but wouldn't it be easier to invoke CConnman::Stop() from CConnman::~CConnman, and then call g_connman.reset() at the time you'd stop?
As discussed on IRC, yes. This is over-engineered as-is, for future threading scenarios that may not ever happen. I'll make that change.
In the case of (for example) an already-running bitcoind, the shutdown sequence
begins before CConnman has been created, leading to a null-pointer dereference
when g_connman->Stop() is called.
Instead, Just let the CConnman dtor take care of stopping.
Replaced with the simpler version.
