[qa] wallet: Check legacy wallet as well #8716

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1609-qaWalletLegacy changing 1 files +3 −2

MarcoFalke commented at 7:54 PM on September 13, 2016: member

After setting the default of usehd to true, we are no longer testing the legacy wallet.

This pull makes wallet.py test both wallets over time.
MarcoFalke added the label Wallet on Sep 13, 2016
MarcoFalke added the label Tests on Sep 13, 2016

MarcoFalke commented at 8:33 PM on September 13, 2016: member

Unrelated travis failure in untouched script:

stderr:
   File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 151, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 598, in run_test
    self.test_compactblock_construction()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/p2p-compactblocks.py", line 248, in test_compactblock_construction
    assert(self.test_node.last_cmpctblock is not None)

in qa/rpc-tests/wallet.py:None in fafdc405a7 outdated

  20 | @@ -20,7 +21,9 @@ def __init__(self):
  21 |          self.num_nodes = 4
  22 |  
  23 |      def setup_network(self, split=False):
  24 | -        self.nodes = start_nodes(3, self.options.tmpdir)
  25 | +        extra_args = [['-usehd={:d}'.format(random.random()>.5)] for _ in range(3)]

laanwj commented at 9:10 AM on September 14, 2016:

Please use a deterministic sequence here, not random

MarcoFalke force-pushed on Sep 14, 2016
[qa] wallet: Check legacy wallet as well fa644d0053
MarcoFalke force-pushed on Sep 14, 2016
laanwj merged this on Sep 19, 2016
laanwj closed this on Sep 19, 2016
laanwj referenced this in commit 9ac01301f5 on Sep 19, 2016
MarcoFalke deleted the branch on Sep 19, 2016
luke-jr referenced this in commit e34374e252 on Sep 21, 2016
codablock referenced this in commit e38839aaa0 on Sep 19, 2017
codablock referenced this in commit 699db99321 on Jan 11, 2018
andvgal referenced this in commit b473d67784 on Jan 6, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

MarcoFalke

laanwj

Labels

Wallet Tests