To protect against possible invalidation and to bring conformity to the code.
[WALLET] Addition of ImmatureCreditCached to MarkDirty() #8717
pull spencerlievens wants to merge 1 commits into bitcoin:master from spencerlievens:patch-2 changing 1 files +1 −0-
spencerlievens commented at 10:30 PM on September 13, 2016: contributor
-
a56037805c
[WALLET] Addition of ImmatureCreditCached to MarkDirty()
To protect against possible invalidation and to bring conformity to the code.
-
spencerlievens commented at 10:31 PM on September 13, 2016: contributor
-
laanwj commented at 5:43 AM on September 14, 2016: member
Did you really have to open another pull for this?
- jonasschnelli added the label Wallet on Sep 14, 2016
-
jonasschnelli commented at 6:28 AM on September 14, 2016: contributor
utACK https://github.com/bitcoin/bitcoin/pull/8717/commits/a56037805c68bf34331a6a05d487ae4872261538
This indeed does fix a possible issue with the immature credit cache. It certain situations, the immature balance could show an old cache value even after calling
CWalletTx::MarkDirty()). -
jonasschnelli commented at 6:35 AM on September 14, 2016: contributor
And I agree with @laanwj. Opening another PR (#8703 did the same thing) seems inappropriate and disturbing (just for the next time). I also recommend to be conservative with pining developers directly.
-
spencerlievens commented at 2:25 PM on September 14, 2016: contributor
I made a new PR simply because I was using a non-public GitHub account and thought it better to use my public GitHub account instead.
-
MarcoFalke commented at 2:35 PM on September 14, 2016: member
@spencerlievens You could have just fixed the author of the commit and force pushed.
-
spencerlievens commented at 3:08 PM on September 14, 2016: contributor
@MarcoFalke Good point ;)
- laanwj merged this on Dec 21, 2016
- laanwj closed this on Dec 21, 2016
- laanwj referenced this in commit 38e4887b46 on Dec 21, 2016
- ryanofsky referenced this in commit 2242ec50e7 on Dec 21, 2016
- ryanofsky referenced this in commit 7084fc0c0a on Dec 21, 2016
- ryanofsky referenced this in commit 818d735ed3 on Jan 2, 2017
- ryanofsky referenced this in commit 52045d1bb7 on Jan 4, 2017
- luke-jr referenced this in commit d29538d061 on Feb 27, 2017
- ryanofsky referenced this in commit 7ed143c10e on Mar 1, 2017
- practicalswift referenced this in commit 65b9bca9ff on Apr 27, 2017
- deadalnix referenced this in commit 88232d52a9 on Jan 14, 2018
- MarcoFalke locked this on Sep 8, 2021
