Move logic for TX INVs together #8727

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:MoreGranularDebug4 changing 1 files +6 −9

rebroad commented at 5:01 PM on September 14, 2016: contributor

No description provided.
Move logic for TX INVs together facf08b159

in src/main.cpp:None in facf08b159

5237 | @@ -5238,8 +5238,13 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv,
5238 |  
5239 |              if (inv.type == MSG_TX) {
5240 |                  inv.type |= nFetchFlags;
5241 | +                pfrom->AddInventoryKnown(inv);
5242 | +                if (fBlocksOnly)
5243 | +                    LogPrint("tx", "transaction (%s) inv sent in violation of protocol peer=%d\n", inv.hash.ToString(), pfrom->id);

paveljanik commented at 5:52 PM on September 14, 2016:

In this case, you are being notified about network issue - some peer violated protocol (with some tx). Ping pong between tx and net has no reason here...

paveljanik commented at 5:55 PM on September 14, 2016:

Hint: what other inv.type can you see?

rebroad closed this on Sep 14, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

rebroad

paveljanik