[qa] Fix broken sendcmpct test in p2p-compactblocks.py #8739

1. 
   sdaftuar commented at 4:40 PM on September 15, 2016: member

   Apparently the way lambda's were being used in the first test done by p2p-compactblocks.py was busted, which was masking several bugs in the test.

   So I redid it a different way that seems to work correctly (I verified that passing in negated predicates causes test failure, which wasn't the case before), and fixed a few other bugs that came up:

   • sendcmpct messages need to be synchronized with RPC calls to generate()
   • headers must be synced in order for bitcoind to announce compact blocks
   • The last sendcmpct test omitted sending a sendcmpct message (so the test shouldn't have been passing as it was written).

   I think this should be tagged for backport.

2. Fix broken sendcmpct test in p2p-compactblocks.py

   Python lambda use was incorrect.
   
   sendcmpct messages need to be synchronized with RPC calls to generate().
   
   Headers need to be synced (eg with getheaders) for cmpctblock announcements
   to start.
   
   Last test omitted sending a sendcmpct message.

   157254a4bf
3. fanquake added the label Tests on Sep 16, 2016
4. fanquake added the label Needs backport on Sep 16, 2016
5. MarcoFalke added this to the milestone 0.13.1 on Sep 16, 2016
6. 
   btcdrak commented at 1:52 PM on September 20, 2016: contributor

   utACK 157254a

7. laanwj approved
8. 
   laanwj commented at 2:21 PM on September 20, 2016: member

   https://github.com/bitcoin/bitcoin/pull/8739/commits/157254a4bfdfc4ca3ad5bf2d84e82f290bd0c7f2

9. laanwj merged this on Sep 20, 2016
10. laanwj closed this on Sep 20, 2016

    ---

11. laanwj referenced this in commit 1c24d5f637 on Sep 20, 2016
12. laanwj referenced this in commit cef633ce63 on Sep 26, 2016
13. 
    laanwj commented at 2:59 PM on September 26, 2016: member

    This is backported in #8815, removing tag

14. laanwj removed the label Needs backport on Sep 26, 2016
15. gladcow referenced this in commit 421b745fdd on Mar 2, 2018
16. gladcow referenced this in commit 7d11dc6c68 on Mar 13, 2018
17. gladcow referenced this in commit 5035e1ba7e on Mar 14, 2018
18. gladcow referenced this in commit 3a405d4fb6 on Mar 15, 2018
19. gladcow referenced this in commit f19e31e9f0 on Mar 15, 2018
20. gladcow referenced this in commit 2cc2bf267e on Mar 24, 2018
21. gladcow referenced this in commit caae165aa5 on Apr 4, 2018
22. UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
23. lateminer referenced this in commit 79a8a8b012 on Oct 21, 2018
24. andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
25. CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
26. MarcoFalke locked this on Sep 8, 2021

Milestone
0.13.1