rpc listsinceblock hash is not correctly filtering double-spends #8752

1. 
   FrozenPrincess commented at 11:28 pm on September 17, 2016: none

   Describe the issue

   Testing in bitcoin 0.13.0, calling bitcoin-cli listsinceblock x is outputting all double-spent transactions that are in the wallet, even those that were double-spent well and truly before x.

   Is the issue reproducible?

   Yes

   List steps to reproduce below:

   1. Create a double-spend send to your wallet (easiest using bip125)
   2. Wait until one confirms, and then wait a few more blocks
   3. Run bitcoin-cli listsinceblock $(bitcoin-cli getbestblockhash) and it will output the double spent transaction

   Expected behavior

   The double-spent transaction that was conflicted before the block hash should be filtered

2. fanquake added the label RPC/REST/ZMQ on Sep 18, 2016
3. 
   jonasschnelli commented at 1:11 pm on September 19, 2016: contributor

   #8757 should fix this, though, AFAIK, bitcoin-cli listsinceblock <getbestblockhash> will list nothing (expect the currently wrongly listed conflicted tx), the block(hash) your targeting will not be part of the output.
4. 
   sipa commented at 1:14 pm on September 19, 2016: member

   I think it would be unexpected that transaction ever disappear from RPC output. If you want to stop seeing a transaction, use abandontransaction.
5. 
   FrozenPrincess commented at 1:20 pm on September 19, 2016: none

   I think it would be unexpected that transaction ever disappear from RPC output. If you want to stop seeing a transaction, use abandontransaction.

   Yeah, I don’t think a transaction should ever completely disappear either. However listsinceblock takes a filter (since a block hash), which should filter both old confirmed transactions and old double-spends.

   The normal usage of listsinceblock is you want to see what has happened since the last time you processed the transactions. So you should see all the double-spends that were attempted against you, and all the transactions that have confirmed, and all the unconfirmed transactions. It’s just you don’t want to see the double-spends forever

6. 
   sipa commented at 1:23 pm on September 19, 2016: member

   Sorry, I missed that this was about listsinceblock. I agree.
7. 
   mchrostowski commented at 4:32 pm on May 26, 2017: contributor

   @FrozenPrincess Could you elaborate on how you do step 1 (the double spend), I’ve been trying to reproduce and have had no luck so far. Thank you.
8. 
   FrozenPrincess commented at 4:40 pm on May 26, 2017: none

   @mchrostowski Easiest way is to use bip125. You can use a site like https://coinb.in to do this, or add walletrbf=1 in your bitcoin config and then send money to yourself and then use bumpfee to generate a conflicting transaction.
9. adamjonas referenced this in commit 0343924d26 on Oct 21, 2019
10. 
    adamjonas commented at 7:14 pm on October 25, 2019: member

    Confirmed this is still an issue and opened #17258 to address.
11. meshcollider closed this on Nov 5, 2019

    ---

12. sidhujag referenced this in commit c06d5017eb on Nov 7, 2019
13. sidhujag referenced this in commit cc82e86c7f on Nov 10, 2020
14. MarcoFalke locked this on Dec 16, 2021
15. PastaPastaPasta referenced this in commit b32c629f01 on Feb 26, 2022
16. PastaPastaPasta referenced this in commit bf28d4d63d on Feb 26, 2022
17. PastaPastaPasta referenced this in commit 0cb659ebb9 on Mar 1, 2022
18. PastaPastaPasta referenced this in commit ae63b6c18e on Mar 5, 2022
19. PastaPastaPasta referenced this in commit e0455f3437 on Mar 5, 2022
20. PastaPastaPasta referenced this in commit 4c1a5ebb6e on Mar 5, 2022
21. Munkybooty referenced this in commit 45c0e65800 on May 23, 2022
22. Munkybooty referenced this in commit 6864a4d842 on May 23, 2022
23. Munkybooty referenced this in commit 253f51a428 on May 30, 2022
24. Munkybooty referenced this in commit 38e074dc4c on Jun 7, 2022
25. Munkybooty referenced this in commit 5014cd6a3f on Jun 8, 2022
26. Munkybooty referenced this in commit 8b0456ce8e on Jun 16, 2022
27. Munkybooty referenced this in commit ed851548d4 on Jul 6, 2022
28. Munkybooty referenced this in commit 29e2d0a026 on Aug 3, 2022
29. Munkybooty referenced this in commit 54049f3c79 on Aug 16, 2022
30. Munkybooty referenced this in commit c18fa09027 on Aug 22, 2022
31. Munkybooty referenced this in commit d839dd4c1e on Aug 24, 2022

Contributors
FrozenPrincess jonasschnelli sipa mchrostowski adamjonas

Labels
RPC/REST/ZMQ