[0.13] Backports

luke-jr commented at 9:44 am on September 21, 2016: member

Bugfixes, QA, and copyright headers (checked that no old/removed code needed approval)

One thing it’s missing is removal of the qt4.6 depends package. Not sure if that should be backported or not.

Current to master as of 1c24d5f637201b46a621f6e8e0247bc8bdc52f6a

add witness address to address book

Github-Pull: #8693
Rebased-From: 62ffbbdec30699941069baeae61716ff12155ba6

c6a629100b

Update btcdrak signing key

Github-Pull: #8662
Rebased-From: 46606af200db563ca742b56f291cee2311a27491

733760a700

Update p2p-segwit.py to reflect correct AskFor behavior

Github-Pull: #8528
Rebased-From: bc1d1f266046ec79e87c7bf90aaf279f43266cf5

3606b6b3a7

p2psegwit.py transaction is rejected due to premature witness not size

Github-Pull: #8528
Rebased-From: 5547aeb0159027912069b4773184963f54c672af

a114a0208b

Fix SIGHASH_SINGLE bug in test_framework SignatureHash

The value for "other" inputs should be -1 (0xffffffffffffffff) instead of 0

Github-Pull: #8667
Rebased-From: 2f2548d5e0ccea6879eb7b0b851d61ad2f544423

6b07362b37

[Qt][CoinControl] fix UI bug that could result in paying unexpected fee

Github-Pull: #8678
Rebased-From: 04802930d4e1f565b3c36e1a806fbe9cd4809937

8e03382279

Clear witness with vin/vout in CWallet::CreateTransaction()

Github-Pull: #8664
Rebased-From: c40b034327bf8a30d3af1eeeef84bc4ccd57e685

091cdebfb8

Add configure check for -latomic

Github-Pull: #8563
Rebased-From: 878faacd7b3daac437cc689b13422f6432fb5cd0

147003c73e

update name of file bitcoin.qrc

Github-Pull: #8683
Rebased-From: df2d2e70cac8d15ecc30bc5c46930fd27c8afac0

8a7d7ffe65

Fix obvious assignment/equality error in test

Github-Pull: #8673
Rebased-From: 426e7bce0e365e0947f932ca46bcc48ca3a2f10e

03b01966fa

prepend license statement to indirectmap

Add statement about MIT licensing to indirectmap.h. I forgot the license
preamble when I originally wrote the file.

Github-Pull: #8414
Rebased-From: d3af342276f29d2bd162628eb4b669599633e39e

1f21d161a5

[QA] Add walletdump RPC test (including HD- & encryption-tests)

Github-Pull: #8417
Rebased-From: 54af51d98d0b38f08c58dd589bff81883aee2854

f70be14f8f

net: Ignore `notfound` P2P messages

Github-Pull: #8427
Rebased-From: 5c9e49d12c931f9c7ddaac0144739dcd7263e554

69d1cd202d

[qa]: add parsing for '<host>:<port>' argument form to rpc_url()

Github-Pull: #8400
Rebased-From: 0ff4375c93bd159233282de5a33ad2e6c1e79841

e111904a76

[qa]: enable rpcbind_test

Github-Pull: #8400
Rebased-From: 9bbb414b800cf71f93f15d2cb5d4cf32c72294e6

bea02dc3b6

Enable size accounting in mining unit tests

Github-Pull: #8419
Rebased-From: 8bfd70817bf8b8b07b81660e47c88dd122b7423f

a7aa3ccc4f

[qa] Rework hd wallet dump test

Github-Pull: #8442
Rebased-From: fa4439d3554435bdf0ef47861835f10d41bcdc1a

8bb1efd985

Update README.md

Updating documentation for adding new unit test files

Removing unneeded sentence from README

Removing uint160_tests.cpp as it DNE

Formatting command line instructions to use ``

fixing 80 char formatting issue in README

fixing more nits

Github-Pull: #8428
Rebased-From: b8db185952c815444b7052092472ef9af3a42e89

9b0097976f

Use a signal to continue init after genesis activation

Github-Pull: #8392
Rebased-From: 0fd2a33648ccde4b989f1d69529daea4d88b14a2

30eac2d79a

Add extra message to avoid a long 'Loading banlist'

Github-Pull: #8392
Rebased-From: aa59f2ed3f378c02159e41ff3ae2df76ef850577

3b354d213f

Do diskspace check before import thread is started

Github-Pull: #8392
Rebased-From: 9d4eb9ad99f7c3abf7abaeaf7ea51f98f9445e75

fc349288cb

[doc] typos, READMEs, comments

Just a quick run through some docs and fixing some text errors.

Github-Pull: #8503
Rebased-From: e11f9a2f0244f1d6e34b50293b2ecca61a356bed

749c8a5655

configure: Allow building bench_bitcoin by itself

Github-Pull: #8492
Rebased-From: 216d796ce006df36427c03f0c209c48472d65bef

8b0bdd3923

Bugfix: Allow building libbitcoinconsensus without any univalue

Github-Pull: #8293
Rebased-From: 8a270b25fc90495ce4b98b6d6e954fce92135dc1

fa5b2498ca

Corrected JSON typo on setban of net.cpp

Github-Pull: #8512
Rebased-From: 6ffd996b8ee5f36ed4490410385f9b072da5889b

156e305dc1

Fix a type error that would not compile on Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)

Github-Pull: #8513
Rebased-From: 8194a6e525514d5cda85ac08273a6ffb6d5b6cac

4e5fc31ae6

various typos

Github-Pull: #8505
Rebased-From: 1aacfc2da521a8e0d718e9ac561d9b2d7916eb0b

befe654f0f

[qa] abandonconflict: Use assert_equal

Github-Pull: #8531
Rebased-From: fa64306520156af1d1fe90e92f6cc22ffa097c02

a27cdd8edf

document return value of networkhashps for getmininginfo RPC endpoint

Github-Pull: #8461
Rebased-From: 65f4532f13a89cacc4909072601d71ee7ebae5c5

b17a3f9e5a

[Wallet] Trivial cleanup of HD wallet changes

Github-Pull: #8443
Rebased-From: 7e5d94df1fb09ed7ee7ed50032f876972ef39489

464dedd6ab

Use __func__ to get function name for output printing

Github-Pull: #8548
Rebased-From: fa785d121152c652d0704ac32ce8611262e609d2

305d8ac90b

Add copyright header to wallet_text_fixture.cpp

I created the file but forgot to add this header.

Github-Pull: #8558
Rebased-From: 653bb3d64057f11c5c9a8f539ba57be549097cee

75d548475d

CDB: fix debug output

It doesn't really help to clear a variable before printing it to the debug log.

Github-Pull: #8539
Rebased-From: fab2e26d2033ca3c7a24f6a0ad6529fceda52ebc

cb07f19e90

Trivial: Fix two VarInt examples in serialize.h

Github-Pull: #8560
Rebased-From: 7bd5ff46237b06b3cf223176c1c71ef66383fa92

c493f43621

[doc] Update git-subtree-check.sh README

Github-Pull: #8545
Rebased-From: fa3d9740099c8513f9942983f135f58890e62cb5

863ae74a1f

Set jonasschnellis dns-seeder filter flag

Github-Pull: #8573
Rebased-From: 40a95cfd8f21bedbf35016b920f26c19bfb25c69

4f84082a74

init: Fix typo in help message for -whitelistforcerelay

Reported by pryds on Transifex in the Danish translation.

Github-Pull: #8607
Rebased-From: 67a55025a1ea5d0461139cd6764686a77524feed

9556745dc2

[qa] pull-tester: Don't mute zmq ImportError

Github-Pull: #8607
Rebased-From: fabfd5dae28cbe26e71d50dbfb6feab03673f27a

c18a9ca788

[doc] Fix typos in comments, doxygen: Fix comment syntax

Github-Pull: #8607
Rebased-From: fa27c0a2c4545a579bf339e816c3fa785252b7dc

486650ae6a

contrib: Make fix-copyright-headers.py more portable

Github-Pull: #8607
Rebased-From: fafe7b3432d5117e3f207eafe2fca1f9637b24f6

752fbae697

[doc] - clarify statement about parallel jobs in rpc-tests.py

Github-Pull: #8625
Rebased-From: 14675610245e951f2b922a0eaad6eb7d011ae87e

0a35573534

Berkeley DB v6 compatibility fix

Fixes building error looking like this:
CXX wallet/libbitcoin_wallet_a-db.o
wallet/db.cpp: In member function ‘void CDBEnv::EnvShutdown()’:
wallet/db.cpp:46:16: error: call of overloaded ‘DbEnv(int)’ is ambiguous
DbEnv(0).remove(strPath.c_str(), 0);
^
wallet/db.cpp:46:16: note: candidates are:
In file included from wallet/db.h:21:0,
from wallet/db.cpp:6:
/usr/include/db_cxx.h:916:2: note: DbEnv::DbEnv(const DbEnv&)
DbEnv(const DbEnv &);
^
/usr/include/db_cxx.h:518:2: note: DbEnv::DbEnv(DB_ENV)
DbEnv(DB_ENV *dbenv);
^
/usr/include/db_cxx.h:516:2: note: DbEnv::DbEnv(u_int32_t)
DbEnv(u_int32_t flags);
^
Makefile:5780: recipe for target 'wallet/libbitcoin_wallet_a-db.o' failed
make[2]: ** [wallet/libbitcoin_wallet_a-db.o] Error 1

Github-Pull: #8626
Rebased-From: 323a5fe06af43d3922a435e696d6c52acc6fade1

ea51b0f5dd

net: No longer send local address in addrMe

After #8594 the addrFrom sent by a node is not used anymore at all,
so don't bother sending it.

Also mitigates the privacy issue in (#8616). It doesn't completely solve
the issue as GetLocalAddress is also called in AdvertiseLocal, but at
least when advertising addresses it stands out less as *our* address.

Github-Pull: #8740
Rebased-From: d9c99c3058c90f4f7075cf5c495b8dcd2e7519a7

42ea51a65f

[qa] walletbackup: Sync blocks inside the loop

Github-Pull: #8724
Rebased-From: fad41f308f5e0e0650e3eed96c8c8575b3f7c33e

da94272e3c

[Doc] Target protobuf 2.6 in OS X build notes.

Homebrew now installs Protobuf version 3 by default, which doesn't currently compile. Install Protobuf 2.6.x from the versions tap instead.

Github-Pull: #8754
Rebased-From: b16a7f609fdb2efa9a8a1b82f09748b95b5ae4f6

0e2c6bdf78

Minor change in section name

Changed 'build' to 'create', as the section name have changed in newer versions of release-process.md

Github-Pull: #8720
Rebased-From: dad932c241a3fe9ef8e4dc36596381666ab4f879

5e15fce30c

Specify Protobuf version 2 in paymentrequest.proto

Github-Pull: #8742
Rebased-From: c4084c208509c42f796ebaa3eaded5f1cd40c506

d31ac725cf

[qa] wallet: Check legacy wallet as well

Github-Pull: #8716
Rebased-From: fa644d0053ca40740b9e7b8982ff6c5d5640e4af

e34374e252

UndoReadFromDisk works on undo files (rev), not on block files.

Github-Pull: #8737
Rebased-From: b4fb51271905f9ef39e5c2bc7e8c15e7489394a1

084cae9ca5

[copyright] add MIT License copyright header to zmq_sub.py

Github-Pull: #8701
Rebased-From: 37a7fe9e440b83e2364d5498931253937abe9294

9a903f9f00

[copyright] add MIT License copyright header to remaining Python files

Github-Pull: #8702
Rebased-From: 4677b197f7aa8d35bfc20a5961c3e1c41bb7de39

ea2a6bef85

[copyright] Add missing copyright headers

Github-Pull: #8676
Rebased-From: 783e930e68a312bc7654d833053cceead18dd688

a60d7cc97d

[copyright] add MIT license headers to .sh scripts where missing

Years are set according to 'git log' history

Github-Pull: #8700
Rebased-From: 0766d1cac38d7ea27a6323d7ca206154b2686f9b

702fd2ee21

Trivial: Fix typo

Github-Pull: #8762
Rebased-From: 12a721b45e16124f48ea85f96079feec18e948ca

b70b4a24e6

MarcoFalke added the label Backport on Sep 21, 2016

laanwj commented at 5:02 am on September 22, 2016: member

One thing it’s missing is removal of the qt4.6 depends package. Not sure if that should be backported or not.

It’s not a bug fix, nor critical, so no. Cleanups in general don’t need to be backported unless they facilitate later backporting of critical changes, which here is not the case.

laanwj commented at 1:34 pm on September 26, 2016: member

utACK b70b4a2, commit list looks good to me.

MarcoFalke commented at 1:51 pm on September 26, 2016: member

“commit list looks good to me”-ACK b70b4a2

laanwj merged this on Sep 26, 2016

laanwj closed this on Sep 26, 2016

laanwj referenced this in commit 254e990ce5 on Sep 26, 2016

MarcoFalke locked this on Sep 8, 2021

[0.13] Backports #8772