[Doc] Add missing autogen to example builds #8787

pull AmirAbrams wants to merge 1 commits into bitcoin:master from AmirAbrams:patch-1 changing 1 files +2 −0

AmirAbrams commented at 3:18 AM on September 22, 2016: contributor

The Windows cross-compile build examples are missing the autogen.sh step. Without that step, configure doesn't exist and you get this error:

bash: ./configure: No such file or directory

Using Ubuntu 16.04 64 bit.
laanwj added the label Docs and Output on Sep 22, 2016
laanwj commented at 3:22 AM on September 22, 2016: member

ACK.

Using Ubuntu 16.04 64 bit.

If you are cross-compiling from Ubuntu 16.04 I'd suggest reading #8732 #8653 #8730 #8511, there are serious current compatibility issues.
luke-jr commented at 3:23 AM on September 22, 2016: member

configure comes with the source code packages. You should not be using git unless you are a developer.
laanwj commented at 3:25 AM on September 22, 2016: member

But in practice most people following this guide seem to be cloning from git. No one uses the source tarball. It's mostly developers that follow this guide in the first place. Also IIRC we mention autogen.sh in all other places (such as build-unix.md).

It could ofc. be added that it is optional.
AmirAbrams commented at 3:42 AM on September 22, 2016: contributor

@luke-jr I always build from git but I am a developer and thought the document was intended for developers. If not, then please close my PR but like @laanwj points out, build-osx.md and build-unix.md reference the autogen.sh step. Maybe I can add an if/fi that checks for the configure file or explain the example is for source code packages?
laanwj commented at 3:46 AM on September 22, 2016: member

Maybe I can add an if/fi that checks for the configure file or explain the example is for source code packages?

Maybe just add a comment after it # not required when building from tarball. Adding a fi/if construction sounds like overkill, and anyhow this is based on information only the user can know.

in doc/build-windows.md:None in e4c064b6f2 outdated

  26 | @@ -27,15 +27,15 @@ To build executables for Windows 32-bit:
  27 |      cd depends
  28 |      make HOST=i686-w64-mingw32 -j4
  29 |      cd ..
  30 | -    ./configure --prefix=`pwd`/depends/i686-w64-mingw32
  31 | +    ./autogen.sh && ./configure --prefix=`pwd`/depends/i686-w64-mingw32

MarcoFalke commented at 10:49 PM on September 22, 2016:

Agree with @laanwj

MarcoFalke changes_requested
AmirAbrams commented at 10:55 PM on September 22, 2016: contributor
Is it okay like this?
```
cd ..
./autogen.sh # not required when building from tarball
./configure --prefix=`pwd`/depends/i686-w64-mingw32
```
If you agree, I will make the change and squash into one commit.
[Doc] Add missing autogen to example builds 3f58a283ee
AmirAbrams commented at 1:17 AM on September 24, 2016: contributor

I made the corrections and squashed my commits.
laanwj merged this on Sep 25, 2016
laanwj closed this on Sep 25, 2016
laanwj referenced this in commit 279bbadc8b on Sep 25, 2016
codablock referenced this in commit aac3dfea79 on Sep 19, 2017
codablock referenced this in commit 24c4116b58 on Jan 11, 2018
andvgal referenced this in commit 019f390bc5 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels