[trivial] fix mempool comment (outdated by BIP125) #8796

pull jnewbery wants to merge 1 commits into bitcoin:master from jnewbery:trivial_comment changing 1 files +10 −7

jnewbery commented at 5:54 PM on September 22, 2016: member

[trivial] Comment in txmempool.h was outdated by BIP 125 and is now incorrect. This PR fixes that comment.
sdaftuar commented at 6:30 PM on September 22, 2016: member

ACK
dcousens approved
jonasschnelli added the label Docs and Output on Sep 23, 2016
jonasschnelli approved
jonasschnelli commented at 6:17 AM on September 23, 2016: contributor

ACK

in src/txmempool.h:None in 4e271b589b outdated

 342 | + * local node), but not all transactions seen are added to the pool. For
 343 | + * example, the following new transactions will not be added to the mempool:
 344 | + * - a new transaction that double-spends an input of a transaction already in
 345 | + * the pool where the new transaction does not meet the Replace-By-Fee
 346 | + * requirements as defined in BIP 125.
 347 | + * - a non-standard transaction.

laanwj commented at 7:18 AM on September 25, 2016:

Also transactions that don't make the minimum fee requirements.

jnewbery commented at 12:56 PM on September 26, 2016:

Thanks. I've added that and squashed my commits.

[trivial] fix mempool comment (outdated by BIP125) c14ffd524b
jnewbery force-pushed on Sep 26, 2016
laanwj merged this on Sep 26, 2016
laanwj closed this on Sep 26, 2016
laanwj referenced this in commit 8f1fbf36a7 on Sep 26, 2016
jnewbery deleted the branch on Sep 26, 2016
codablock referenced this in commit e25018154b on Sep 19, 2017
codablock referenced this in commit 4a917b1b35 on Jan 11, 2018
andvgal referenced this in commit 11639b442d on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels