This reduce the number of repeated tests in p2p-segwit.py for segwit signature hashes, to prevent timeout.
I'm not sure if this is only my problem but the test always fail with timeout on my machine during "Testing segwit signature hash version 1".
Ping regularly in p2p-segwit.py to keep connection alive #8803
pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:patch-17 changing 1 files +3 −0-
jl2012 commented at 8:28 AM on September 24, 2016: contributor
- fanquake added the label Tests on Sep 24, 2016
-
laanwj commented at 6:24 AM on September 25, 2016: member
Why would repeated tests cause a timeout? Shouldn't the timeout be per test and not in total?
-
jl2012 commented at 12:49 PM on September 25, 2016: contributor
The error comes from https://github.com/jl2012/bitcoin/blob/67719326f70e9e421879ee6e0a2a8fbafc25c083/qa/rpc-tests/p2p-segwit.py#L1437
Unexpected exception caught during testing: ConnectionResetError(54, 'Connection reset by peer')
-
0637b02fce
Ping regularly in p2p-segwit.py to keep connection alive
This pings regularly while building a big block in p2p-segwit.py, to prevent timeout
- jl2012 force-pushed on Sep 25, 2016
- jl2012 renamed this:
Reduce number of repeated tests in p2p-segwit.py
Ping regularly in p2p-segwit.py to keep connection alive
on Sep 25, 2016 -
jl2012 commented at 3:46 PM on September 25, 2016: contributor
Seems it takes too long to build the block and the connection is closed. Pinging regularly could solve the problem
-
laanwj commented at 10:28 AM on September 26, 2016: member
Sounds like a good idea
-
MarcoFalke commented at 2:51 PM on September 26, 2016: member
ACK 0637b02fce04c800acc6747687c91c9b22f642e5
- laanwj merged this on Sep 27, 2016
- laanwj closed this on Sep 27, 2016
- laanwj referenced this in commit 6e54c85439 on Sep 27, 2016
- MarcoFalke added the label Needs backport on Sep 27, 2016
- MarcoFalke added this to the milestone 0.13.1 on Sep 27, 2016
- MarcoFalke referenced this in commit 375437c26b on Oct 3, 2016
-
- laanwj removed the label Needs backport on Oct 13, 2016
- laanwj removed this from the milestone 0.13.1 on Oct 13, 2016
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels