Do not include env_win.cc on non-Windows systems #8826

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160928_leveldb_no_win changing 1 files +0 −1

paveljanik commented at 2:42 PM on September 28, 2016: contributor
This solves https://github.com/bitcoin-core/leveldb/pull/8

The file env_win.cc is included twice on Windows and once for all other systems. But it is not needed at all there.

This removes this warning on OS X:
```
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/ranlib: file: leveldb/libleveldb.a(leveldb_libleveldb_a-env_win.o) has no symbols
```
Do not include env_win.cc on non-Windows systems 7e5fd7198e
laanwj commented at 2:50 PM on September 28, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/8826/commits/7e5fd7198e3b1fae65e1feec7dae7c0083e28203
laanwj added the label Build system on Sep 28, 2016
laanwj assigned theuni on Sep 29, 2016
theuni commented at 3:21 PM on September 29, 2016: member

This currently matches the upstream behavior, though it's clearly not right. utACK 7e5fd7198e3b1fae65e1feec7dae7c0083e28203
laanwj commented at 3:26 PM on September 29, 2016: member

This currently matches the upstream behavior, though it's clearly not right.

That's our own fault, env_win.cc doesn't exist in the real upstream. It's a simplified windows platform created by me to work around windows-shutdown-during-sync issues in upstream. See https://github.com/bitcoin-core/leveldb/pull/9 and #6917 .
laanwj merged this on Sep 29, 2016
laanwj closed this on Sep 29, 2016
laanwj referenced this in commit f560d9564f on Sep 29, 2016
codablock referenced this in commit 24414bc8f1 on Sep 19, 2017
codablock referenced this in commit 272fddce2c on Jan 12, 2018
andvgal referenced this in commit a8b3c0e764 on Jan 6, 2019
zkbot referenced this in commit 59d6a92e7d on Sep 22, 2020
zkbot referenced this in commit 514d868179 on Sep 25, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels