[qa] Split up slow RPC calls to avoid pruning test timeouts #8827

1. 
   sdaftuar commented at 3:58 PM on September 28, 2016: member

   After #8524, CTxMemPool::check() can take much longer when the mempool is full of large transactions, such as the transactions used in pruning.py, because we're rehashing everything in the mempool. Consequently I've been seeing consistent test failures due to an RPC timeout at the point in pruning.py where 220 blocks are generated, because mempool.check() is called on each block, and many blocks need to be mined before the mempool is drained.

   This PR works around the slowdown by splitting up the RPC call.

   As mempool consistency checking is off by default on mainnet, I don't think this is an issue outside of the testing framework, so for now I don't think it's worth modifying/optimizing the work being done in CTxMemPool::check() over this.

2. [qa] Split up slow RPC calls to avoid pruning test timeouts a0f8482f3e
3. MarcoFalke added the label Tests on Sep 28, 2016
4. MarcoFalke added the label Refactoring on Sep 28, 2016
5. MarcoFalke added the label Needs backport on Sep 28, 2016
6. MarcoFalke added this to the milestone 0.13.1 on Sep 28, 2016
7. 
   MarcoFalke commented at 5:39 PM on September 28, 2016: member

   utACK a0f8482f3e9b07e37c3f1b6fa09683b448810955

8. 
   btcdrak commented at 10:57 AM on September 29, 2016: contributor

   utACK a0f8482

9. MarcoFalke merged this on Sep 29, 2016
10. MarcoFalke closed this on Sep 29, 2016

    ---

11. MarcoFalke referenced this in commit cc9e8aca5f on Sep 29, 2016
12. MarcoFalke referenced this in commit 9bbe66e592 on Oct 3, 2016
13. MarcoFalke removed the label Needs backport on Oct 13, 2016
14. MarcoFalke removed this from the milestone 0.13.1 on Oct 13, 2016
15. MarcoFalke added this to the milestone 0.12.2 on Oct 13, 2016
16. MarcoFalke added this to the milestone 0.13.1 on Oct 13, 2016
17. MarcoFalke removed this from the milestone 0.12.2 on Oct 13, 2016
18. codablock referenced this in commit 5dd26e0713 on Sep 19, 2017
19. codablock referenced this in commit cf4bdab3b5 on Jan 12, 2018
20. andvgal referenced this in commit 1fc0dd1162 on Jan 6, 2019
21. MarcoFalke locked this on Sep 8, 2021

Contributors

sdaftuarMarcoFalkebtcdrak

Milestone
0.13.1