[qa] nulldummy.py: Don't run unused code #8835

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1610-qaNulldummyUnused changing 1 files +4 −6
  1. MarcoFalke commented at 1:35 PM on September 29, 2016: member

    nulldummy.py accidentally imports too much and executes unused code

  2. [qa] nulldummy: Don't run unused code fa156c604e
  3. MarcoFalke added the label Tests on Sep 29, 2016
  4. MarcoFalke added the label Needs backport on Sep 29, 2016
  5. MarcoFalke added this to the milestone 0.13.1 on Sep 29, 2016
  6. laanwj commented at 2:32 PM on September 29, 2016: member

    Tested ACK https://github.com/bitcoin/bitcoin/pull/8835/commits/fa156c604e7d86d84f7731b05d7530bc91d2736b

    Tests fully pass on FreeBSD with:

    • #8835 [qa] nulldummy.py: Don't run unused code #8835
    • #8834 [qa] blockstore: Switch to dumb dbm
    • #8839 test: Avoid ConnectionResetErrors during RPC tests
  7. laanwj merged this on Sep 29, 2016
  8. laanwj closed this on Sep 29, 2016

  9. laanwj referenced this in commit 2dd57e4f9f on Sep 29, 2016
  10. MarcoFalke deleted the branch on Sep 29, 2016
  11. jl2012 commented at 3:57 PM on September 29, 2016: contributor

    Sorry, I'm not familiar with the testing framework and just copy-and-pasted some codes from other tests

  12. laanwj commented at 4:02 PM on September 29, 2016: member

    @jl2012 I didn't notice it either when I looked through it, this was a good catch by @MarcoFalke

  13. MarcoFalke referenced this in commit d87227d6d2 on Oct 3, 2016
  14. MarcoFalke removed the label Needs backport on Oct 13, 2016
  15. codablock referenced this in commit 4a585b2f20 on Jan 30, 2018
  16. andvgal referenced this in commit f77a7fcc8f on Jan 6, 2019
  17. CryptoCentric referenced this in commit 81f02fa9da on Feb 28, 2019
  18. CryptoCentric referenced this in commit dd0f5e63e4 on Mar 2, 2019
  19. MarcoFalke locked this on Sep 8, 2021
Labels

Milestone
0.13.1


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me