Implement (begin|end)_ptr in C++11 and add deprecation comment #8850

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2016_09_beginptr_deprecation changing 2 files +18 −11

laanwj commented at 3:28 PM on September 30, 2016: member

Implement begin_ptr and end_ptr in serialize.h in terms of C++11 code, and add a comment that they are deprecated.

Follow-up to developer notes update in 654a211.

Also add a data() method to prevector, this is necessary to support this.

prevector: add C++11-like data() method

This returns a pointer to the beginning of the vector's data.

47314e6daa

laanwj added the label Utils and libraries on Sep 30, 2016
dcousens approved
btcdrak commented at 7:05 PM on October 1, 2016: contributor

utACK e9059ac
btcdrak approved

serialize: Deprecate `begin_ptr` / `end_ptr`

Implement `begin_ptr` and `end_ptr` in terms of C++11 code,
and add a comment that they are deprecated.

Follow-up to developer notes update in 654a21162252294b7dbd6c982fec88008af7335e.

f00705ae7f

laanwj force-pushed on Oct 2, 2016
laanwj commented at 7:52 AM on October 2, 2016: member

Removed a stray 'noexcept' from the prevector.h patch, it came in from std::vector's .data() implementation but we use that keyword nowhere else not convinced we should now.
theuni commented at 1:11 AM on October 4, 2016: member

utACK f00705ae7ff3c1db805859e3be41e58ac70625b6
laanwj merged this on Oct 4, 2016
laanwj closed this on Oct 4, 2016
laanwj referenced this in commit 7dce175f5d on Oct 4, 2016
codablock referenced this in commit 5daa8a3589 on Sep 19, 2017
codablock referenced this in commit 6e4dad98a6 on Jan 12, 2018
andvgal referenced this in commit abe27f2015 on Jan 6, 2019
Fuzzbawls referenced this in commit 8dfc4806f7 on May 19, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels