[qa] Fix race condition in p2p-compactblocks test #8854

1. 
   sdaftuar commented at 1:09 AM on October 1, 2016: member

   Also fix a bug in the sync_with_ping() helper function.

   I believe this fixes #8842. For others trying to debug -- I was able to reproduce the issue by setting the deliver_sleep_time in NodeConnCB to 0.5 seconds, and then confirm that this patch fixes it.

   I think there are likely other places in the tests where wait_until() may be used with incorrect arguments, just like the bug fix to sync_with_ping(). I'll try to clean those up in another PR.

2. [qa] Fix race condition in p2p-compactblocks test

   Also fix a bug in the sync_with_ping() helper function

   b5fd666984
3. 
   btcdrak commented at 7:20 AM on October 1, 2016: contributor

   Nicely found.

   ACK b5fd666

4. fanquake added the label Tests on Oct 1, 2016
5. MarcoFalke added the label Needs backport on Oct 1, 2016
6. MarcoFalke added this to the milestone 0.13.1 on Oct 1, 2016
7. MarcoFalke merged this on Oct 1, 2016
8. MarcoFalke closed this on Oct 1, 2016

   ---

9. MarcoFalke referenced this in commit 6faffb8a83 on Oct 1, 2016
10. MarcoFalke referenced this in commit 624a007f47 on Oct 3, 2016
11. MarcoFalke removed the label Needs backport on Oct 13, 2016
12. gladcow referenced this in commit 0362db6ba8 on Mar 2, 2018
13. gladcow referenced this in commit 1f82587fb1 on Mar 13, 2018
14. gladcow referenced this in commit 41bd8aefa9 on Mar 14, 2018
15. gladcow referenced this in commit a6339b15f9 on Mar 15, 2018
16. gladcow referenced this in commit fd08fe84a0 on Mar 15, 2018
17. gladcow referenced this in commit d364ac5fef on Mar 24, 2018
18. gladcow referenced this in commit 3d1804fcfe on Apr 4, 2018
19. UdjinM6 referenced this in commit bc45a2f87a on Apr 11, 2018
20. lateminer referenced this in commit 90f833fe60 on Oct 21, 2018
21. andvgal referenced this in commit fd5c50bc2b on Jan 6, 2019
22. CryptoCentric referenced this in commit dd3fd51204 on Feb 28, 2019
23. MarcoFalke locked this on Sep 8, 2021

Milestone
0.13.1