Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs #8856

1. 
   jtimon commented at 6:33 am on October 1, 2016: contributor

   A lot of noise just to get one less GetArg call from util.cpp. But explicit is better than implicit, specially if we ever want to decouple the util building package from global variables, or at least separate them in single file for each building module.
2. Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs 3450c18a12
3. fanquake added the label Refactoring on Oct 1, 2016
4. 
   laanwj commented at 5:36 pm on October 2, 2016: member

   Yes, makes sense. Removing side effects is a good thing.

   At some point we we need to make our own implementation of the config parser instead of boost::options. This will be less hacky if we have a proper API instead of just slinging values into global maps.

5. 
   laanwj commented at 8:50 am on October 3, 2016: member

   ut/code review ACK https://github.com/bitcoin/bitcoin/pull/8856/commits/3450c18a125f125aec76bfef79c69317eaad935d
6. 
   MarcoFalke commented at 9:11 am on October 3, 2016: member

   utACK 3450c18
7. laanwj merged this on Oct 3, 2016
8. laanwj closed this on Oct 3, 2016

   ---

9. laanwj referenced this in commit a7e5cbb209 on Oct 3, 2016
10. codablock referenced this in commit 873e598d83 on Sep 19, 2017
11. codablock referenced this in commit 14483e46f9 on Jan 12, 2018
12. zkbot referenced this in commit f1aeaec471 on Mar 21, 2018
13. andvgal referenced this in commit 42e7b9bff0 on Jan 6, 2019
14. zkbot referenced this in commit 4fc490c430 on Dec 4, 2019
15. zkbot referenced this in commit 868c63f92d on Dec 4, 2019
16. furszy referenced this in commit 0255df35a6 on Apr 26, 2021
17. MarcoFalke locked this on Sep 8, 2021

Contributors
jtimon laanwj MarcoFalke

Labels
Refactoring