Rationale: I find myself sometimes needing to get the address for a payment again, and doing so by double-clicking to open the request dialog to copy it. Putting it right there on the context menu seems reasonable. (I am adding Copy URI instead of Copy Address because in the future payment requests might not use addresses.)
Qt: Add "Copy URI" to payment request context menu #8918
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:gui_req_copy_uri changing 2 files +33 −8-
luke-jr commented at 11:30 PM on October 13, 2016: member
-
Qt: Add "Copy URI" to payment request context menu 21f5a6364d
- fanquake added the label GUI on Oct 14, 2016
-
laanwj commented at 7:42 AM on October 15, 2016: member
Concept ACK
-
jonasschnelli commented at 6:36 AM on October 17, 2016: contributor
Concept ACK. I understand the point of "Copy URI", but wouldn't "Copy Address/URI" be more appropriate until BIP70 has broader usage?
-
luke-jr commented at 8:21 AM on October 17, 2016: member
I don't understand the question. "Copy URI" works today for all payment requests (address or BIP70) and is supported by pretty much every wallet.
-
laanwj commented at 1:51 PM on October 17, 2016: member
wouldn't "Copy Address/URI" be more appropriate until BIP70 has broader usage?
It always copies an URI right? If so, we should not make the message longer and more complex.
-
jonasschnelli commented at 8:31 AM on October 18, 2016: contributor
It always copies an URI right? If so, we should not make the message longer and more complex.
Right. I was confused.
Tested ACK 21f5a6364d5bad738d51e75ff96c8f8b88557d11
- laanwj merged this on Oct 18, 2016
- laanwj closed this on Oct 18, 2016
- laanwj referenced this in commit 47ace4240a on Oct 18, 2016
- codablock referenced this in commit e726e19d36 on Sep 7, 2017
- UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels