Adds minimum ping to the debug information, and replaces the last ping with the minimum ping in the node list.
qt: Display minimum ping in debug window. #8925
pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:DebugWindowMinPing changing 7 files +34 −10-
rebroad commented at 1:45 PM on October 15, 2016: contributor
-
Display minimum ping in debug window. 1724a405c9
- MarcoFalke added the label RPC/REST/ZMQ on Oct 15, 2016
- MarcoFalke added the label GUI on Oct 15, 2016
-
paveljanik commented at 3:49 PM on October 15, 2016: contributor
Why replacing? Isn't the last ping time more valuable? Why renaming the member variable?
-
rebroad commented at 4:20 AM on October 16, 2016: contributor
@paveljanik Good questions, which perhaps I ought to have proactively explained.
Minimum ping is used in disconnection logic for evicting incoming connections, so a way it is the more relevant value.
Renaming the variable so that it is consistent with the RPC variable.
- MarcoFalke removed the label RPC/REST/ZMQ on Oct 16, 2016
-
MarcoFalke commented at 9:24 AM on October 16, 2016: member
utACK 1724a40
- MarcoFalke renamed this:
Display minimum ping in debug window.
qt: Display minimum ping in debug window.
on Oct 16, 2016 -
paveljanik commented at 6:45 AM on October 17, 2016: contributor
-
jonasschnelli commented at 6:46 AM on October 17, 2016: contributor
Yes. Why not. utACK 1724a405c9065f2c939e936aca9b5d37fca5e954
- laanwj merged this on Oct 18, 2016
- laanwj closed this on Oct 18, 2016
- laanwj referenced this in commit f628d9a29a on Oct 18, 2016
- luke-jr referenced this in commit 9667f768aa on Dec 21, 2016
- codablock referenced this in commit ef05e748ea on Sep 7, 2017
- UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels