Add script tests for FindAndDelete in pre-segwit and segwit scripts #8927

pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:findanddeletetest changing 3 files +51 −2
  1. jl2012 commented at 4:45 PM on October 15, 2016: contributor

    This adds FindAndDelete tests for pre-segwit and segwit scripts, to show that FindAndDelete is performed only in pre-segwit scripts. The transaction is generated in an unconventional way: the public key is generated with key recovery, using a fixed signature (committed in prevout) and a known sighash.

    Also edited the comments in interpreter.cpp since the rationale of dropping the signature was wrong.

    No harm to backport but I don't feel this is needed. This is more important for alt-implementations to make sure they won't fork accidentally by incorrectly implementing BIP143.

  2. Add script tests for FindAndDelete in pre-segwit and segwit scripts acf853df91
  3. fanquake added the label Tests on Oct 15, 2016
  4. jonasschnelli commented at 6:41 AM on October 17, 2016: contributor

    utACK acf853df910339412bafb1743f42af1774f5b910

  5. laanwj commented at 3:15 PM on October 19, 2016: member
  6. laanwj merged this on Oct 19, 2016
  7. laanwj closed this on Oct 19, 2016

  8. laanwj referenced this in commit 475d68252e on Oct 19, 2016
  9. NicolasDorier commented at 11:05 AM on October 25, 2016: contributor

    tACK with NBitcoin, thanks, this is tricky test to create

  10. luke-jr referenced this in commit 387ec9d963 on Dec 2, 2016
  11. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-02 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me