`getblocktemplate` help needs to document `rules` option #8946

issue laanwj opened this issue on October 17, 2016
  1. laanwj commented at 8:57 PM on October 17, 2016: member

    This is mandatory with segwit but not documented.

    20:43 < sipa> Lightsword: you need to pass some extra parameter to indicate the miner supports segwit
    20:43 < Lightsword> sipa, how do I do that with bitcoin-cli?
    20:45 < sipa> $ ./bitcoin-cli -testnet getblocktemplate '{"rules":["segwit"]}'
    20:46 < wumpus> seems that's not documented in the help for the request
    20:46 < wumpus> just 'capabilities' and 'mode'; 'rules' is only shown as a reply field
    20:46 < sipa> though the help text does refer to https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki#getblocktemplate_changes
    20:49 < sipa> but we should update the help output 
    

    Also the type of jsonrequestobject is mentioned to be a string, but it is a JSON object that needs to be passed in.

  2. laanwj added the label Docs and Output on Oct 17, 2016
  3. laanwj renamed this:
    `getblocktemplate` help needs to document "rules" option
    `getblocktemplate` help needs to document `rules` option
    on Oct 17, 2016
  4. MarcoFalke commented at 8:59 PM on October 17, 2016: member

    I moved the additional comment to #8945

  5. MarcoFalke closed this on Oct 17, 2016

  6. DrahtBot locked this on Sep 8, 2021
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me