Do not invoke anti-DoS system for invalid BIP16 transactions #896

1. 
   sipa commented at 6:06 pm on February 25, 2012: member

   Doing so would allow an attack on old nodes, which would relay a standard transaction spending a BIP16 output in an invalid way, until reaching a new node, which will disconnect their peer.

   Reported by makomk on IRC.

2. Do not invoke anti-DoS system for invalid BIP16 transactions

   Doing so would allow an attack on old nodes, which would relay a
   standard transaction spending a BIP16 output in an invalid way,
   until reaching a new node, which will disconnect their peer.
   
   Reported by makomk on IRC.

   db9f2e0117
3. 
   makomk commented at 9:08 pm on February 25, 2012: none

   Looks good to me!

   Note that this isn’t exactly an attack on old nodes though. Unless it’s increased recently, under half of all blocks mined are from P2SH nodes, which means that they’d probably be the ones that would be most affected by the Bitcoin network attempting to partition itself into old and new nodes in this way. Then there’s the issue of giving an attacker a tool that helps them create a network partition with a useful proportion of miners on each side in the first place.

   I also wonder if a similar issue will apply to blocks after P2SH is switched on fully; could they cause the P2SH part of the network to cut itself off from the non-P2SH part?

4. 
   gavinandresen commented at 9:25 pm on February 25, 2012: contributor

   ACK, nice fix.
5. gavinandresen merged this on Feb 27, 2012
6. gavinandresen closed this on Feb 27, 2012

   ---

7. suprnurd referenced this in commit 9c302a77da on Dec 5, 2017
8. ptschip referenced this in commit cc951d4ffe on Jan 11, 2018
9. lateminer referenced this in commit b2fcefee93 on Oct 30, 2019
10. DrahtBot locked this on Sep 8, 2021

Contributors
sipa makomk gavinandresen

Milestone
V0.6