Add NodeId to debug info.
TODO (in a later pull request): Make better use of the -logips command line option so that IP addresses are debugged instead of NodeIds in all places where NodeIds are currently debugged.
NodeId missing from this debug line #8963
pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:SocketSendErrorNodeId changing 1 files +1 −1-
rebroad commented at 4:01 PM on October 18, 2016: contributor
-
NodeId missing from this debug line ceb2601822
- MarcoFalke added the label Docs and Output on Oct 18, 2016
-
paveljanik commented at 8:02 PM on October 18, 2016: contributor
ACK https://github.com/bitcoin/bitcoin/pull/8963/commits/ceb26018221144c57fffc15aa4e8419e821ae446
What about grouping all these missing peer numbers into one PR? ;-)
-
rebroad commented at 12:24 AM on October 19, 2016: contributor
@paveljanik yes, well, I will do what I mentioned in the TODO at some point, which will also ensure any missing debug lines get caught (I'm not aware of any others though) and allow all peer= lines to show the IP address instead (although how desired this behvaviour would be, I'm not sure).
-
laanwj commented at 7:10 AM on October 19, 2016: member
Do you really have to open a pull per debug message, and 8 at a time at that? You're annoying everyone by doing this, just stop it.
- laanwj closed this on Oct 19, 2016
-
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels