Coincontrol is a "transaction send settings" structure. There is no use of this outside the wallet.
moveonly: move `coincontrol` to `src/wallet` #8990
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_10_coincontrol_wallet changing 5 files +7 −7-
laanwj commented at 9:50 AM on October 21, 2016: member
-
moveonly: move `coincontrol` to `src/wallet` 1ae5839ff0
- laanwj added the label Wallet on Oct 21, 2016
-
MarcoFalke commented at 11:20 AM on October 21, 2016: member
utACK 1ae5839
-
jonasschnelli commented at 11:25 AM on October 21, 2016: contributor
ACK 1ae5839ff024096c65e1590084f2720fa08d3e23
-
paveljanik commented at 11:48 AM on October 21, 2016: contributor
ACK https://github.com/bitcoin/bitcoin/commit/1ae5839ff024096c65e1590084f2720fa08d3e23
Super-micro-nit: in-place renaming the file make the list of includes non-sorted. The new name should be moved down in the include list. But I understand why it is done this way.
-
laanwj commented at 12:31 PM on October 21, 2016: member
Super-micro-nit: in-place renaming the file make the list of includes non-sorted.
We've given up on include sorting a long time ago.
-
paveljanik commented at 1:00 PM on October 21, 2016: contributor
Yes, but it is de-facto standard and almost every new code follows it. But as I said, it is super-micro(not tm) nit.
- laanwj merged this on Oct 21, 2016
- laanwj closed this on Oct 21, 2016
- laanwj referenced this in commit 3fb3fade3c on Oct 21, 2016
- codablock referenced this in commit a213c5b1b7 on Sep 19, 2017
- codablock referenced this in commit beef6e7841 on Jan 13, 2018
- andvgal referenced this in commit d727041407 on Jan 6, 2019
- CryptoCentric referenced this in commit a4a1768d13 on Feb 15, 2019
- DrahtBot locked this on Sep 8, 2021
Contributors
Labels